Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numba v0.57.0 #115

Merged
merged 17 commits into from
May 19, 2023
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented May 2, 2023

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

  • pygments
  • docopt
  • versioneer-518
  • pygithub
  • gitpython

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/4856418928, please use this URL for debugging.


Fixes #110
Fixes #111
Fixes #112
Fixes #116

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham jakirkham mentioned this pull request May 2, 2023
1 task
@jakirkham
Copy link
Member

Failures here are a result of llvmlite version 0.40.0 not yet being available (as expected). Once that is available, can follow up here

@jakirkham
Copy link
Member

The bot has now opened the llvmlite version 0.40.0 PR ( conda-forge/llvmlite-feedstock#69 )

However CI is encountering some build issues there ( conda-forge/llvmlite-feedstock#69 (comment) )

@igozali
Copy link

igozali commented May 15, 2023

Also do python 3.11 builds need to be added to the config here too?

@jakirkham
Copy link
Member

Depends on PR ( conda-forge/llvmlite-feedstock#66 ), which in turn depends on PR ( conda-forge/llvmlite-feedstock#69 )

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/numba-feedstock/actions/runs/5019174556.

jakirkham added 2 commits May 18, 2023 16:32
This is deprecated and the entry point is already removed.
@jakirkham jakirkham mentioned this pull request May 18, 2023
5 tasks
Needed for CUDA 12+ support.

Keep `cudatoolkit` for legacy cases where users are not pulling
`cuda-version`.
This appears to confuse Numba's test suite in 0.59.0. Given it is a
no-op anyways, just drop it. Likely it was leftover when tweaking the
number of tests run before. The random selection of tests already used
should already be sufficient.
jakirkham added 6 commits May 18, 2023 17:51
This test is fast. So if it fails, will do so quickly. Run early in the
tests to enable faster iteration on related issues.
The `ppc64le` test suite hangs on Travis (and has done so for a few
releases now). Perhaps it is just too much for that CI provider to
handle.

The `aarch64` builds need patches to LLVM to fix some test cases. Those
patches are currently in review at that feedstock. So go ahead and skip
these tests for now. Can re-enable once patched LLVM builds are
released.
Comment on lines -55 to +59
echo 'Running only a slice of tests'
$SEGVCATCH python -m numba.runtests -b -j --random='0.15' --exclude-tags='long_running' -m $TEST_NPROCS -- numba.tests
echo "Skipping numba test suite on $archstr"
#echo 'Running only a random selection of tests'
#$SEGVCATCH python -m numba.runtests -b --random='0.15' --exclude-tags='long_running' -m $TEST_NPROCS -- numba.tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ppc64le builds have been hanging in the test suite for a few releases now ( #102 ). It may just be too much for Travis CI to handle. So skipping those.

Also aarch64 needs some patches to LLVM to fix some test issues ( conda-forge/llvmdev-feedstock#192 ). This is in review. Once new patched LLVM packages are shipped, this should be fixed.

Can open a PR to re-enable the skipped tests after. Then merge once the issues are resolved in the LLVM package. Since we use the LLVM dynamic library, no rebuilding of Numba should be needed to get those fixes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted PR ( #119 ) to try reverting

@jakirkham
Copy link
Member

Have applied the Python 3.11 migrator manually here to add those builds

@jakirkham jakirkham added the automerge Merge the PR when CI passes label May 19, 2023
@github-actions github-actions bot merged commit 13e5825 into conda-forge:main May 19, 2023
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • travis: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 0.57.0_h12652b branch May 19, 2023 06:08
@jakirkham jakirkham mentioned this pull request May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update numba for condage forge Numba: Support CUDA 12
3 participants