Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Release 1.4 #11642

Closed
6 of 7 tasks
larsoner opened this issue Apr 21, 2023 · 10 comments
Closed
6 of 7 tasks

MAINT: Release 1.4 #11642

larsoner opened this issue Apr 21, 2023 · 10 comments
Milestone

Comments

@larsoner
Copy link
Member

larsoner commented Apr 21, 2023

We should release 1.4 in a week or two if possible. I've gone through and bumped milestones on a bunch of issues/PRs to 1.5 and left what I think is hopefully doable for 1.4 here.

@mne-tools/mne-python-steering-committee if you want, feel free to take a look at the open issues and PRs early next week and mark things you think can realistically get in within a short time frame for 1.4!

Steps:

@larsoner larsoner added this to the 1.4 milestone May 1, 2023
@larsoner
Copy link
Member Author

larsoner commented May 1, 2023

Looking at https://github.com/mne-tools/mne-python/milestone/25 I think the only blocker that isn't a PR by me is the documentation one #6794 @drammock . I'm thinking we should try to release by the end of the week. Let me know if there's anything you want me to wait for in #6794, otherwise I'll get the release process going once my PRs are in.

@drammock
Copy link
Member

drammock commented May 1, 2023

the old docs issue (#6794) doesn't have any blockers IMO. But getting our conf.py and CSS in sync with recent changes to the theme is on my list for this week (resuming work on it today in fact).

@larsoner
Copy link
Member Author

larsoner commented May 2, 2023

FYI https://github.com/numba/numba/releases/tag/0.57.0 just landed so it's possible that we might be able to use Python 3.11 in our installers if the conda-forge machinery works without issue in the next few days!

EDIT: I'm watching conda-forge/numba-feedstock#115 to monitor progress

@larsoner
Copy link
Member Author

larsoner commented May 3, 2023

It would be really helpful if conda-forge/staged-recipes#22453 gets merged in the next two days, too. I'd like to add mne-gui-addons to the installers and can't without it :(

@hoechenberger
Copy link
Member

@larsoner I reached out to the team via gitter, let's see if somebody gets back to us

@hoechenberger
Copy link
Member

It got merged!

@larsoner
Copy link
Member Author

larsoner commented May 4, 2023

@drammock ready for release from your end? If so I'll get the process going tomorrow

@drammock
Copy link
Member

drammock commented May 4, 2023

I think we're good to go. I thought there were some lingering deprecations to remove (related to topomap param changes IIRC) but now I'm not finding them. One possibile breaking change that might be good to sneak in is the TODO item here:

plot_kwargs["picks"] = "all" # TODO: this should be the default

(it refers to Spectrum.plot even though the TODO item is in a utils file) If you have time to do that, great. If not I can do tomorrow morning if you're willing to not start the release first thing. Or it can wait until next version.

@larsoner
Copy link
Member Author

larsoner commented May 4, 2023

Feel free to do it tomorrow when you get a chance

@larsoner
Copy link
Member Author

larsoner commented May 5, 2023

Don't want to start the release process this late on a Friday because it risks having to fix stuff over the weekend. I'll start it Monday instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants