Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.0.17.1 (bugfix backport) #8

Merged
merged 32 commits into from
Dec 10, 2024
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 9, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

xref: NVIDIA/numba-cuda#86

conda-forge-webservices[bot] and others added 22 commits October 8, 2024 15:03
Co-authored-by: Bradley Dice <[email protected]>
@bdice bdice changed the base branch from main to 0.0.17 December 9, 2024 22:27
@bdice bdice marked this pull request as ready for review December 9, 2024 22:27
@bdice bdice requested a review from gmarkall as a code owner December 9, 2024 22:27
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found some lint.

Here's what I've got...

For recipe/recipe.yaml:

  • ❌ There are 1 too many lines. There should be one empty line at the end of the file.
  • ❌ noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipe/recipe.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python ${{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >=${{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python ${{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).
  • ℹ️ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12245459229. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 9, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/recipe.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python ${{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >=${{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python ${{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12247460361. Examine the logs at this URL for more detail.

recipe/recipe.yaml Outdated Show resolved Hide resolved
recipe/recipe.yaml Outdated Show resolved Hide resolved
recipe/recipe.yaml Show resolved Hide resolved
recipe/recipe.yaml Outdated Show resolved Hide resolved
recipe/recipe.yaml Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

jakirkham commented Dec 9, 2024

Think the networkx recipe may serve as a good example. They moved to the new format with the python_min changes in PR: conda-forge/networkx-feedstock#66

bdice and others added 2 commits December 9, 2024 18:11
Co-authored-by: jakirkham <[email protected]>
recipe/recipe.yaml Outdated Show resolved Hide resolved
@bdice bdice requested a review from jakirkham December 10, 2024 00:11
@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub Actions workflow below for more details. You can also ping conda-forge/core (using the @ notation) for further assistance or you can try rerendering locally.

The following suggestions might help debug any issues:

  • Is the recipe/{meta.yaml,recipe.yaml} file valid?
  • If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
  • Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12246993076. Examine the logs at this URL for more detail.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bradley! 🙏

Had a suggestion below

Then would try re-rendering again

recipe/recipe.yaml Show resolved Hide resolved
@bdice
Copy link
Contributor Author

bdice commented Dec 10, 2024

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub Actions workflow below for more details. You can also ping conda-forge/core (using the @ notation) for further assistance or you can try rerendering locally.

The following suggestions might help debug any issues:

  • Is the recipe/{meta.yaml,recipe.yaml} file valid?
  • If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
  • Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12247315373. Examine the logs at this URL for more detail.

recipe/recipe.yaml Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bradley! 🙏

@bdice bdice merged commit 4be02f5 into conda-forge:0.0.17 Dec 10, 2024
4 checks passed
@jakirkham
Copy link
Member

Looks like Azure didn't start when this was merged

Have manually started Azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants