Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix find_spec for old finders that don't implement it. #86

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

vyasr
Copy link
Collaborator

@vyasr vyasr commented Dec 9, 2024

The code in https://github.com/NVIDIA/numba-cuda/blob/v0.0.17/site-packages/_numba_cuda_redirector.py#L70 is incompatible with legacy finders (pre-Python 3.4) that do not implement the find_spec method. This makes numba-cuda incompatible with Google Colab (see googlecolab/colabtools#5000). For the purpose of RAPIDS 24.12, which is an early adopter of numba-cuda, we need this fix to go into a patch release of 0.0.17 because RAPIDS 24.12 is incompatible with numba-cuda>=0.0.18.

@vyasr vyasr marked this pull request as draft December 9, 2024 19:20
@vyasr
Copy link
Collaborator Author

vyasr commented Dec 9, 2024

Marking as draft until we can figure out our merging/release strategy. Since numba-cuda has only released patch versions up until now, we will either need to add another release segment just for this case, or make a post release. RAPIDS 24.12 is pinned to <0.0.18 due to incompatibilities that introduces, see rapidsai/cudf#17359.

@jameslamb
Copy link
Member

we will either need to add another release segment just for this case, or make a post release.

Copying what I wrote offline... I think we should release this as 0.0.17.1 (adding another component to the version number just for this purpose). This type of change deserves to be a patch release, not a post release, and I can't think of any negative consequences of using a 4-part version for this... it doesn't mean we're committing to 4-part version numbers forever or even for the next release after this.

@gmarkall gmarkall changed the base branch from main to v0.0.17-patches December 9, 2024 20:44
@gmarkall
Copy link
Collaborator

gmarkall commented Dec 9, 2024

Ah, crumbs. I rebased this to a branch starting on v0.0.17 and Github's now pulling in all the history from the main branch.

@gmarkall
Copy link
Collaborator

gmarkall commented Dec 9, 2024

My plan here was:

  • Retarget this PR to the v0.0.17-patches branch, which starts from the v0.0.17 tag
  • Merge this into that branch
  • Bump the version to 0.0.17.1 in a new PR
  • Merge the version bump PR, then upload the resulting packages to anaconda.org and pypi

@vyasr
Copy link
Collaborator Author

vyasr commented Dec 9, 2024

Rebased accordingly.

@vyasr vyasr marked this pull request as ready for review December 9, 2024 21:03
@gmarkall gmarkall added the 5 - Ready to merge Testing and reviews complete, ready to merge label Dec 9, 2024
@gmarkall gmarkall merged commit 963a7d9 into NVIDIA:v0.0.17-patches Dec 9, 2024
27 checks passed
@vyasr vyasr deleted the fix/find_spec branch December 10, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to merge Testing and reviews complete, ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants