Update to 3.08 #20
Update to 3.08 #20
Conversation
jaimergp
requested review from
jakirkham,
mbargull,
msarahan and
patricksnape
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2022.07.06.01.52.02
…nda-forge-pinning 2022.07.06.01.52.02
|
Running it locally with the downloaded artifact does print something: It's using the build date I guess? |
|
The issue was already present in 3.06.1, btw: |
|
Explicitly passing |
…nda-forge-pinning 2022.07.06.01.52.02
|
Ready for review @conda-forge/nsis! |
|
Is this still blocking on: conda/constructor#526 |
|
I issued repodata patches for |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2022.11.03.19.49.57
|
@jakirkham @mbargull - this is ready for review whenever you have time :D |
|
Gentle ping @conda-forge/nsis :D |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2022.11.13.03.29.29
|
Looks like everything is in order. I'll merge to unblock the |
| folder: plugins/UAC | ||
| - url: https://github.com/mingwandroid/nsis-untgz/archive/5c814c5f2c8a9a14e3a6ddd3e594fcc76db5b86a.zip | ||
| sha256: ae68c41493abbb8800640acdf67a06c63bcceaaf21b539c50c348a20dc4b2803 | ||
| folder: plugins/untgz | ||
| - url: https://github.com/mingwandroid/nsis-UnicodePathTest/archive/fa74caef553883f1820049d89e169aff57551796.zip | ||
| sha256: 1a4dc09f0fbb7d6be88835c50a7c95dbd37470c65e29cf676b14e3ad9c4d7494 | ||
| folder: plugins/UnicodePathTest | ||
| # AccessControl does not provide historical versions as far as I can tell.. | ||
| # this is for version v1.0.8.3 - 24th February 2021 | ||
| - url: https://nsis.sourceforge.io/mediawiki/images/4/4a/AccessControl.zip |
There was a problem hiding this comment.
Please upload this archive somewhere and use that instead of using an unstable link like this
There was a problem hiding this comment.
Good point. I blindly copied from the Anaconda feedstock (https://github.com/AnacondaRecipes/aggregate/blame/master/nsis-feedstock/recipe/meta.yaml#L28) but it's true we should probably mirror these like it's being done in the other cases.
| - url: https://code.kliu.org/misc/elevate/elevate-1.3.0-redist.7z | ||
| sha256: b1b3f070353a0eadee2cea3a575049d10df9763ff24e39313da4cec9455382e1 | ||
| folder: plugins/elevate | ||
| - url: http://nsis.sourceforge.net/mediawiki/images/7/79/UAC_v0.2.2d.zip | ||
| sha256: 9e64d93185e468fb873925db887f637778d926b864b5ff85600b7c9fce92660d | ||
| - url: https://nsis.sourceforge.io/mediawiki/images/8/8f/UAC.zip |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Updates to latest version, bringing some more plugins so it's in sync with defaults. Future work on
constructorwill require this version for EXE signing.