Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stable links #23

Closed
jakirkham opened this issue Jan 27, 2023 · 12 comments · Fixed by #24
Closed

Use stable links #23

jakirkham opened this issue Jan 27, 2023 · 12 comments · Fixed by #24
Assignees

Comments

@jakirkham
Copy link
Member

jakirkham commented Jan 27, 2023

Currently the links seem to be changing here. We need to pick something that is static

#20 (comment)

#20 (comment)

cc @isuruf

@jaimergp
Copy link
Member

Hm, I had not seen those comments, sorry! I'll address them next week.

@jaimergp jaimergp self-assigned this Jan 27, 2023
@jakirkham
Copy link
Member Author

No worries. Thanks for following up 🙏

@jakirkham
Copy link
Member Author

We could just upload those on a (date-based?) tag on this repo

@jakirkham
Copy link
Member Author

@jezdez , appears Anaconda has the same issue with this recipe. Maybe we can coordinate on the solution here?

@jaimergp
Copy link
Member

Given how important NSIS is for the installers, maybe something like conda/nsis-mirror which the community can control (instead of personal repos), would be super welcome?

@jakirkham
Copy link
Member Author

In the past we've just attached this sort of thing to the feedstock directly. We can always add maintainers. It's a pretty lightweight solution

That said, don't have strong feelings. @isuruf , what do you think?

@jezdez
Copy link
Member

jezdez commented Feb 1, 2023

@jezdez , appears Anaconda has the same issue with this recipe. Maybe we can coordinate on the solution here?

Yeah, that's a good idea, I've filed an internal ticket about this so that @skupr-anaconda and others can take a look.

@jezdez
Copy link
Member

jezdez commented Feb 1, 2023

For the record, the recipe for nsis lives (IIUC) here: https://github.com/AnacondaRecipes/aggregate/blob/master/nsis-feedstock/recipe/meta.yaml

@dbast
Copy link
Member

dbast commented Feb 1, 2023

why not use a repo in one of the Github orgs (conda-forge/conda/conda-incubator/AnacondaRecipes), uploads and changes can then be done via PRs... I am not aware of an internal Anaconda WebService that allows binary uploads via PR so that uploads and its operation are transparent to everybody.

@jaimergp
Copy link
Member

jaimergp commented Feb 1, 2023

We basically need something like https://github.com/kichik/nsis but with synced Releases (not just tags) that bundle the binary artifacts, and all the plugins.

@jaimergp
Copy link
Member

I added some logic in a fork of that repo. We can transfer it to conda-incubator or similar once we are happy with it.

@jaimergp
Copy link
Member

The mirror is now ready, and a PR is ready for review: #24

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants