Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mamba 2 for the base installation of Miniforge #715
base: main
Are you sure you want to change the base?
Use mamba 2 for the base installation of Miniforge #715
Changes from all commits
e682bd6
bbcf282
bbfe368
f90665c
a5b25eb
cd9613d
cfcafd8
6f354be
11191a2
cd352ab
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side-note: I am not sure about the source of CA certificates
libmamba 1
uses, butlibmamba 2
uses the system's CA certificates by default now, so the trust store storing them now needs to be mounted.Are there other scripts or docker image usage in miniforge or conda-forge for which the trust store will need to be mounted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, everything depends on
openssl
package from conda-forge which usesca-certificates
package in conda-forge. So,libmamba=2
behaviour is wrong.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so this might explain issues like mamba-org/mamba#3570.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once downloaded, micromamba should just work "offline" no internet or certificates required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mamba-org/mamba#3765 aims at resolving it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewers: are there other commands or behaviors one could test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewers:
MAMBA_ROOT_PREFIX
and the shell hook will be set in the shell profile file by the installation script if users choose to have it run during the installation, which is not the case here.I would also like to test when this is the case if possible.