Use mamba 2 for the base installation of Miniforge #715
Conversation
jjerphan
force-pushed
the
mamba-2
branch
2 times, most recently
from
c3c4c99 to
5c99450
Compare
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
|
Yes, I am adding a few command to create an environment, install and uninstall package to test. I want to make sure that it is not brittle. |
Great thanks! I just merged a few using github's interface to resolve some merge conflicts. Got one last mamba1 version out ;) |
|
I guess we could have conda 25.1.0 part of this once conda-forge/conda-feedstock#256 is merged. |
|
Currently:
I am trying to see what's the best way to install CA certificates on the machines. |
If i recall correctly i just run the base docker images, so however yo uwould do it for the respective docker images (ubuntu based vs fedora based) |
Signed-off-by: Julien Jerphanion <[email protected]>
|
A similar error was reported in mamba-org/mamba#3570 |
|
Miniforge/mamba needs to work even if the OS has outdated certificates. Trying to fix the docker image is not the solution here. |
|
@jaimergp: IIRC, you told me once that you observe this exact problem, and we were wondering whether this was due to |
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
| @@ -84,3 +107,44 @@ python -c "import platform; print(platform.machine())" | |||
| python -c "import platform; print(platform.release())" | |||
|
|
|||
| echo "***** Done: Testing installer *****" | |||
|
|
|||
| echo "***** Testing the usage of mamba main commands *****" | |||
There was a problem hiding this comment.
Note for reviewers: are there other commands or behaviors one could test?
| echo "***** Initialize the current session for mamba *****" | ||
| export MAMBA_ROOT_PREFIX="/root/miniforge" | ||
| eval "$(mamba shell hook --shell bash)" |
There was a problem hiding this comment.
Note for reviewers: MAMBA_ROOT_PREFIX and the shell hook will be set in the shell profile file by the installation script if users choose to have it run during the installation, which is not the case here.
I would also like to test when this is the case if possible.
| @@ -37,5 +37,6 @@ for TEST_IMAGE_NAME in ${TEST_IMAGE_NAMES}; do | |||
| echo "============= Test installer on ${TEST_IMAGE_NAME} =============" | |||
| docker run --rm \ | |||
| -v "$(pwd):${CONSTRUCT_ROOT}" -e CONSTRUCT_ROOT \ | |||
| --platform "linux/${DOCKER_ARCH}" "${DOCKER_ARCH/\//}/${TEST_IMAGE_NAME}" /construct/scripts/test.sh | |||
| -v /etc/ssl/certs:/etc/ssl/certs:ro \ | |||
There was a problem hiding this comment.
Side-note: I am not sure about the source of CA certificates libmamba 1 uses, but libmamba 2 uses the system's CA certificates by default now, so the trust store storing them now needs to be mounted.
Are there other scripts or docker image usage in miniforge or conda-forge for which the trust store will need to be mounted?
There was a problem hiding this comment.
Are there other scripts or docker image usage in miniforge or conda-forge for which the trust store will need to be mounted?
No, everything depends on openssl package from conda-forge which uses ca-certificates package in conda-forge. So, libmamba=2 behaviour is wrong.
There was a problem hiding this comment.
OK, so this might explain issues like mamba-org/mamba#3570.
There was a problem hiding this comment.
Once downloaded, micromamba should just work "offline" no internet or certificates required.
There was a problem hiding this comment.
mamba-org/mamba#3765 aims at resolving it.
|
I think we should double check the serialization of URLs in prefix records to make sure that they conform to the "conda standard" (which sadly doesn't exist) - but it should look similar to mamba 1.x / conda / pixi (ie. not URL encoded). |
I can continue mamba-org/mamba#3745 and so that we can have it part of 2.0.6 (cc @maresb), and then we can update this PR to use 2.0.6. Would this work? |
This is a place where micromamba should differ from mamba again then. |
Co-authored-by: Jannis Leidel <[email protected]>
Follow-up of #694 after the merge of conda/constructor#914.
I am looking for ways to test this. For now, the
Miniforgeexample inconda/constructoris the only one element which allows testing it locally.@jaimergp, @hmaarrfk: do you have any recommendations for better testing this? 🙏