Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcublas-dev should depend on cuda-crt-dev_* #29

Merged
merged 1 commit into from
Oct 16, 2024
Merged

libcublas-dev should depend on cuda-crt-dev_* #29

merged 1 commit into from
Oct 16, 2024

Conversation

billysuh7
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@billysuh7 billysuh7 force-pushed the topic/bsuh/libcublas branch 11 times, most recently from 9acf694 to 9455f1e Compare October 7, 2024 22:07
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [111]

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@billysuh7 billysuh7 force-pushed the topic/bsuh/libcublas branch 4 times, most recently from 089c3c0 to 8f80945 Compare October 10, 2024 00:15
@billysuh7 billysuh7 marked this pull request as ready for review October 10, 2024 00:45
@billysuh7 billysuh7 requested a review from a team as a code owner October 10, 2024 00:45
@billysuh7
Copy link
Contributor Author

Just to be sure, purposely taking out any one of cuda-cudart-dev and cuda-crt-dev failed the compilation of test.c

adibbley
adibbley reviewed Oct 10, 2024
View reviewed changes
recipe/meta.yaml Outdated
Comment on lines 105 to 106
- cuda-cudart-dev_{{ target_platform }} {{ cuda_version }}.*
- cuda-crt-dev_{{ target_platform }} {{ cuda_version }}.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- cuda-cudart-dev_{{ target_platform }} {{ cuda_version }}.*
- cuda-crt-dev_{{ target_platform }} {{ cuda_version }}.*
- cuda-cudart-dev_{{ target_platform }}
- cuda-crt-dev_{{ target_platform }}

You should be able to drop the version pin here and let the cuda-version dependency align these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, and will fix this. Thanks.

leofang
leofang reviewed Oct 10, 2024
View reviewed changes
recipe/test.c Show resolved Hide resolved
@billysuh7
libcublas-dev should depend on cuda-crt-dev_*
c54d929 
This is done by adding cuda-cudart-dev to get cuda_runtime.h and adding cuda-crt-dev to get host_defines.h

Also includes rerending changes.
@billysuh7 billysuh7 force-pushed the topic/bsuh/libcublas branch from 8f80945 to c54d929 Compare October 16, 2024 22:25
@billysuh7 billysuh7 merged commit 4d65f26 into conda-forge:main Oct 16, 2024
6 checks passed
@billysuh7 billysuh7 deleted the topic/bsuh/libcublas branch October 16, 2024 23:23
@billysuh7
Copy link
Contributor Author

This PR resolves issue #8

@billysuh7 billysuh7 mentioned this pull request Oct 17, 2024
Closed
jakirkham
jakirkham reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Billy! 🙏

Had one question below

recipe/meta.yaml
Comment on lines +105 to +106
- cuda-cudart-dev_{{ target_platform }}
- cuda-crt-dev_{{ target_platform }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this just meant to be the CRT headers?

Suggested change
- cuda-cudart-dev_{{ target_platform }}
- cuda-crt-dev_{{ target_platform }}
- cuda-crt-dev_{{ target_platform }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We thought all the headers would be found in CRT feedstock alone but it turns out cuda_runtime.h comes from cuda-cudart-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adibbley adibbley adibbley left review comments

@leofang leofang leofang left review comments

@jakirkham jakirkham jakirkham left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@billysuh7 @conda-forge-admin @jakirkham @leofang @adibbley