-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libcublas-dev
should depend on cuda-crt-dev_*
#8
Comments
When compilers are available, we can also add tests that compile a sample executable (but can't run it without a GPU). Suggesting this, which was proposed by @robertmaynard. // test.cpp
#include <cublas_v2.h>
int main() {
cublasStatus_t stat;
cublasHandle_t handle;
stat = cublasCreate(&handle);
return stat != CUBLAS_STATUS_SUCCESS;
} Then we'd depend on compilers in the test and execute something like |
Since |
That’s fine for downstream recipes, but we still need these requirements on the libcublas recipe if users are building applications from source with libcublas. |
Maybe I'm missing something. Thought this was for How is a runtime dependency used here? |
The headers of libcublas require headers from So to compile/use libcublas with a C or C++ compiler you still need the above packages installed to include |
cc @billysuh7 (to look into this further) |
Now that the CRT headers are split out of NVCC as of CUDA 12.2 ( conda-forge/cuda-nvcc-feedstock#32 ), this should be doable It sounds like In terms of cuBLAS packages, these make most sense to add to the |
@jakirkham Running ldd doesn’t check for dlopen, right? Is there a possibility of libcudart being dlopened, like nvrtc in #9? Ultimately I think only library maintainers can provide accurate dependency lists, ldd is “necessary but not sufficient” for accuracy. |
All math libs must link to cudart statically. It's a requirement. |
Great, then I agree we can make progress on this when someone has time. |
I will take this. Thanks. |
Should add the above comment ( #8 (comment) ) was a summary of our discussion in the meeting yesterday ( with feedback from @adibbley and @robertmaynard ) |
libcublas-dev
should depend on cuda-crt-dev_*
Retitled the issue to hopefully make this clearer Thanks Billy! 🙏 |
Closing this issue as it was addressed by PR #29 |
cublas headers depend on cudart headers, which depend on nvcc (crt) headers. We should add these dependencies once those packages are available.
The text was updated successfully, but these errors were encountered: