Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix core version to 10.1.1. #38

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 28, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Closes #37. CMake thinks that version 10.1.1 is actually 10.1.0 without this patch (which seemingly didn't make it into the tag for 10.1.1). See #37 for more details.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bdice
Copy link
Contributor Author

bdice commented Nov 28, 2023

@conda-forge-admin, please rerender

@bdice
Copy link
Contributor Author

bdice commented Nov 28, 2023

@tdegeus This should be ready for review/merge. Thanks again for your help!

@tdegeus tdegeus merged commit c42fe73 into conda-forge:main Nov 28, 2023
7 checks passed
@bdice bdice mentioned this pull request Jan 1, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 10.1.1 reports itself as 10.1.0 in the CMake config.
2 participants