Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 10.1.1 reports itself as 10.1.0 in the CMake config. #37

Closed
1 task done
bdice opened this issue Nov 28, 2023 · 4 comments · Fixed by #38
Closed
1 task done

Version 10.1.1 reports itself as 10.1.0 in the CMake config. #37

bdice opened this issue Nov 28, 2023 · 4 comments · Fixed by #38
Labels
bug Something isn't working

Comments

@bdice
Copy link
Contributor

bdice commented Nov 28, 2023

Solution to issue cannot be found in the documentation.

  • I checked the documentation.

Issue

The 10.1.1 release of fmt didn't update the version in core.h from 10.1.0.

https://github.com/fmtlib/fmt/blob/10.1.1/include/fmt/core.h#L21

As a result, CMake thinks that the version is 10.1.0 instead of 10.1.1.

The version was updated in a separate commit but it doesn't seem like that commit made it into the tag for 10.1.1.

Installed packages

n/a

Environment info

n/a
@bdice bdice added the bug Something isn't working label Nov 28, 2023
@bdice bdice mentioned this issue Nov 28, 2023
5 tasks
@tdegeus
Copy link
Member

tdegeus commented Nov 28, 2023

Thanks for this. Just a question to @vitaut : it would be simpler here if you'd release a v10.1.2 with the fixed (well, with the correct tag then ;)). Would that be something you would consider?

If not, we'll just add the patch here and remove it on the next release.
Separate question, @bdice do you want to add yourself as co-maintainer?

@bdice
Copy link
Contributor Author

bdice commented Nov 28, 2023

I would be happy to co-maintain!

@tdegeus
Copy link
Member

tdegeus commented Nov 28, 2023

Would you please add yourself then in the PR and rerender?

@vitaut
Copy link

vitaut commented Nov 28, 2023

This will be fixed by the next planned version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants