-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arrow-cpp v10.0.1 #875
arrow-cpp v10.0.1 #875
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Please see PR ( #866 ) |
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
@h-vetinari You can also mark PRs as draft to stop the bot from reopening them. |
Cool, didn't know that! |
8ee74e1
to
6bc8a76
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
6bc8a76
to
12d9beb
Compare
So, this PR is doing a couple of things:
While we figure out these issues (help appreciated!), this is a draft. |
@xhochy @pitrou @kou I'm getting
on all platforms... Also, has someone seen the following error before (which happens on windows, but doesn't fail the test section apparently):
PS. Link to previous CI run (since I'm about to force-push) |
f909f03
to
3835d23
Compare
I would have to look into the source but as long as there is no Python dependency, there should also be no NumPy dependency. Due to the nature of NumPy's linking mechanism (which is really great!), you should never see an actual linkage against it. If the warning isn't always showing up, I would be very curious why it happens. All references are filled at runtime through the C function |
It's technically possible. Assuming the CI passes it would not add an extreme maintenance burden, though it depends also whether the other maintainers agree (w.r.t. precedent etc.). But this will be a topic for a separate PR. In any case (and without knowing your constraints obviously), python upgrades have become much less painless, and it should be part of regular dependency hygiene; it's getting high time to move away from 3.7, where the dependency landscape is bitrotting with each passing week (and it's easier to move incrementally than to do 3.7->3.11). |
Thank you for explaining @h-vetinari , understand the overhead and potential path available. I will raise as a separate PR. Yes, would have loved to not be in the situation we are, still reliant on Python 3.7, monolith systems and Vendor/3rd Party system dependencies. Appreciate your time and direction. |
Please do this only after this PR is merged and if you know (at least roughly) how to insert this into |
@conda-forge/arrow-cpp |
Synching after conda-forge/arrow-cpp-feedstock#875, which does quite a lot of things, see this [summary](conda-forge/arrow-cpp-feedstock#875 (review)). I'm not keeping the commit history here, but it might be instructive to check the commits there to see why certain changes came about. It also fixes the CI that was broken by a3ef64b (undoing the changes of #14102 in `tasks.yml`). Finally, it adapts to conda making a long-planned [switch](conda-forge/conda-forge.github.io#1586) w.r.t. to the format / extension of the artefacts it produces. I'm very likely going to need some help (or at least pointers) for the R-stuff. CC @ xhochy (for context, I never got a response to conda-forge/r-arrow-feedstock#55, but I'll open a PR to build against libarrow 10). Once this is done, I can open issues to tackle the tests that shouldn't be failing, resp. the segfaults on PPC resp. in conjunction with `sparse`. * Closes: #14828 Authored-by: H. Vetinari <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedCloses #158
Closes #862
Closes #867
Closes #866
Closes #880
Closes #890
Closes #894
Information about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
Dependency Analysis
We couldn't run dependency analysis due to an internal error in the bot. :/ Help is very welcome!
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3327188129, please use this URL for debugging.