Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable test suite of libarrow #1058

Merged
merged 11 commits into from
Nov 25, 2024
Merged

Conversation

h-vetinari
Copy link
Member

Since #875, we're now running with the test suite for pyarrow. While working on #1048, I wanted to ensure that also the library portion works as intended, so thought about switching on the test suite for libarrow.

After some initial attempts it looks like this is failing, hence will need some iteration together with upstream.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

conda-forge-webservices bot commented Aug 19, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@h-vetinari h-vetinari force-pushed the test_lib branch 2 times, most recently from 26074b3 to afb81ea Compare November 2, 2024 04:45
kou added a commit to apache/arrow that referenced this pull request Nov 15, 2024
)

### Rationale for this change

Enable tests for libarrow in conda-forge: #35587

### What changes are included in this PR?

old glibc does not actually support timezones like `-0117` (used in `StrptimeZoneOffset` test). The exact lower bound for glibc is hard for me to determine; I know that it passes with 2.28 and that it fails with 2.17. Anything in between is an open question. I went with the conservative option here.

### Are these changes tested?

Tested in conda-forge/arrow-cpp-feedstock#1058

### Are there any user-facing changes?

* GitHub Issue: #43808

Lead-authored-by: H. Vetinari <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 23, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12000178104. Examine the logs at this URL for more detail.

@h-vetinari h-vetinari changed the title WIP: Enable test suite of libarrow Enable test suite of libarrow Nov 23, 2024
@h-vetinari
Copy link
Member Author

Alrighty, after over 2 years of working towards this, we now have the C++ tests running for libarrow 🥳

h-vetinari added a commit that referenced this pull request Nov 25, 2024
Enable test suite of `libarrow`
@h-vetinari h-vetinari merged commit ba7b678 into conda-forge:main Nov 25, 2024
13 checks passed
@h-vetinari h-vetinari deleted the test_lib branch November 25, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants