Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v15.0.0 #1290

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Update to v15.0.0 #1290

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b2feeff
Update to v15.0.0
raulcd Jan 22, 2024
77604a1
Add 14.x to abi_migration_branches
raulcd Jan 22, 2024
18825c9
Update testing submodule to match 15.0.0 version and fix tests
raulcd Jan 23, 2024
ba7979e
Add related issues on Arrow repo to Pandas pin and pytest pin
raulcd Jan 30, 2024
69e1182
Skip single test for dlpack that requires cuda instead of all test_dl…
raulcd Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ source:
- patches/0001-fixture-teardown-should-not-fail-test.patch
# testing-submodule not part of release tarball
- git_url: https://github.com/apache/arrow-testing.git
git_rev: 47f7b56b25683202c1fd957668e13f2abafc0f12
git_rev: ad82a736c170e97b7c8c035ebd8a801c17eec170
folder: testing
raulcd marked this conversation as resolved.
Show resolved Hide resolved

build:
Expand Down Expand Up @@ -794,7 +794,7 @@ outputs:

{% set tests_to_skip = "_not_a_real_test" %}
# we do not have GPUs in CI --> cannot test cuda
{% set tests_to_skip = tests_to_skip + " or test_cuda" %}
{% set tests_to_skip = tests_to_skip + " or test_cuda" + " or test_dlpack"%}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is test_dlpack related to CUDA? It doesn't look like it at first glance.

If not, please put it on a separate line, with a separate comment why that skip is there. If the skip is not absolutely unavoidable (like not having a GPU in CI forces us to skip CUDA tests), it should go below # vvvvvvv TESTS THAT SHOULDN'T HAVE TO BE SKIPPED vvvvvvv.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test does require a GPU, I got a failure about that on CI, @AlenkaF am I right here?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last test from test_dlpack.py is related to CUDA: test_dlpack_cuda_not_supported. But it should be skipped if CUDA is not installed, though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! so maybe I can try skipping just that test and run the others. Let me try that.

# skip tests that raise SIGINT and crash the test suite
{% set tests_to_skip = tests_to_skip + " or (test_csv and test_cancellation)" %} # [linux]
{% set tests_to_skip = tests_to_skip + " or (test_flight and test_interrupt)" %} # [linux]
Expand Down
Loading