Update VS Code to 1.61.2 #2005
Merged
Update VS Code to 1.61.2 #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Link to test editor |
3 tasks
enidemi
approved these changes
Nov 12, 2021
seanparsons
approved these changes
Nov 12, 2021
balazsbajorics
approved these changes
Nov 12, 2021
Rheeseyb
added a commit
that referenced
this pull request
Nov 12, 2021
…61.2 * fix(shell.nix) Use nodejs 16 versions of yarn and pnpm * chore(shell.nix) remove test script * fix(shell.nix) Use yarn.js for the yarn executable * chore(shell.nix, release.nix) Update to a more recent nixpkgs * fix(server) Updated the server cabal.project.freeze * chore(vscode) Update VS Code to 1.61.2 (#2005) * Revert "chore(vscode-build) Update vscode build to 1.62.0 (#1995)" (#1998) This reverts commit 464e44a. * fix(editor) Maintain selection while editing arbitrary elements. (#1996) - Fixes #1986. - Remove the check for `event.kind` in `initMessaging` so that backspaces definitely get included. - Add a catch inside `cursorPositionChanged` as a safety measure against failures in there. - Added `walkElementsWithin` to handle `ElementsWithin` for an arbitrary block similarly to `walkElementChildren`. - Factored out `compareAndWalkElements` from `walkElementChildren` so that it could be used in `walkElementsWithin`, adding an additional clause for `JSXArbitraryBlock` instances. - Removed `getHighlightBoundsForUids` as it's unused. - Removed `removeNonExistingViewReferencesFromState` and `elementPathStillExists` as they are unused. * oops I forgot to commit these! * chore(vscode) Re-created the v1.61.2 patch after a botched merge with master * fix(vscode.patch) Again, recreated the patch after another botched merge * fix(shell.nix) Revert an accidental rename of the extension Co-authored-by: Sean Parsons <[email protected]> Co-authored-by: Balazs Bajorics <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to revert the update to 1.62.0 (#1995) because there were issues building it on macos and during the deploy. This PR instead updates us to the previous version, 1.61.2, as that doesn't include the dependency on
@parcel/watcher, which was causing the issue.The issue itself is that unfortunately nix has fallen behind on macos support, relying on a now very outdated SDK (10.12). There is a team working on this, but that appears to be underfunded, and also appears to be resorting in some cases to reverse engineering binaries: NixOS/nixpkgs#101229 (comment)
There is a discourse thread for tracking this here: https://discourse.nixos.org/t/nix-macos-monthly/12330/11, but note this pretty key update from October:
With that in mind, it looks like we indeed need to consider using Docker to provide the base layer.