-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nodejs 16 versions of yarn and pnpm #2001
Conversation
Link to test editor |
Link to test editor |
Link to test editor |
- Fixes #1986. - Remove the check for `event.kind` in `initMessaging` so that backspaces definitely get included. - Add a catch inside `cursorPositionChanged` as a safety measure against failures in there. - Added `walkElementsWithin` to handle `ElementsWithin` for an arbitrary block similarly to `walkElementChildren`. - Factored out `compareAndWalkElements` from `walkElementChildren` so that it could be used in `walkElementsWithin`, adding an additional clause for `JSXArbitraryBlock` instances. - Removed `getHighlightBoundsForUids` as it's unused. - Removed `removeNonExistingViewReferencesFromState` and `elementPathStillExists` as they are unused.
Link to test editor |
Problem:
Yarn and PNPM use their own version of nodejs, meaning we weren't actually using node.js 16 when we thought we were, breaking the build after updating vs code
Fix:
Update the shell.nix to use the node.js 16 versions of yarn and pnpm. Unfortunately due to a strange bug (see NixOS/nixpkgs#145432), the
pkgs.nodePackages_latest
versions of these don't result in a symlink, so we had to manually create those, which also meant copying an override from nix's node-packages/default.nix for pnpm and pnpx.Output: