Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.25.0 #362

Merged
merged 30 commits into from
Mar 29, 2019
Merged

0.25.0 #362

merged 30 commits into from
Mar 29, 2019

Conversation

lasote
Copy link
Contributor

@lasote lasote commented Mar 28, 2019

No description provided.

lasote and others added 24 commits March 7, 2019 16:25
- Fix conan_pip_package. It should be a str by default
- Pass original printer to be re-used by Docker runner
- Add integration test to validate docker run options

Signed-off-by: Uilian Ries <[email protected]>
* Add GitHub settings

- Use standard Conan tags for issues
- Add stale config for timeout bot
- Add issue template

Signed-off-by: Uilian Ries <[email protected]>

* Use Github settings from conanio/docs

Signed-off-by: Uilian Ries <[email protected]>

* #345 Add PR template

- Add PR template to generate the changelog
- Add the contributing guide

Signed-off-by: Uilian Ries <[email protected]>
* #237 Update README

- Add description about the new feature

Signed-off-by: Uilian Ries <[email protected]>

* #237 Upload all dependencies

Signed-off-by: Uilian Ries <[email protected]>

* #237 Unit test to upload all deps

Signed-off-by: Uilian Ries <[email protected]>

* #237 Fix env var name

Signed-off-by: Uilian Ries <[email protected]>

* #237 Fix upload dependencies

Signed-off-by: Uilian Ries <[email protected]>

* #237 Upload only built packages

Signed-off-by: Uilian Ries <[email protected]>

* #237 Only upload when package is available

Signed-off-by: Uilian Ries <[email protected]>
* #147 Support custom PIP command

- Add env var CONAN_PIP_COMMAND which allows to run a specific
  pip version, or even a pip binary path.

Signed-off-by: Uilian Ries <[email protected]>

* #147 Check pip command before to run

- To avoid command injection, the custom pip command will be checked

Signed-off-by: Uilian Ries <[email protected]>

* #147 Test dynamic pip version

- Check for current pip version before to customize CONAN_PIP_COMMAND

Signed-off-by: Uilian Ries <[email protected]>

* #147 Ignore which pip on Windows

Signed-off-by: Uilian Ries <[email protected]>

* #147 pip install quiet mode

Signed-off-by: Uilian Ries <[email protected]>

* #147 Try to fix Windows tests

Signed-off-by: Uilian Ries <[email protected]>
- both string and list are accepted as docker arguments
- Update docker test to use list

Signed-off-by: Uilian Ries <[email protected]>
- Docker is executed in two cases. The first one is when
  we need to download the docker image and patch with the
  newest Conan version. The options were skipped there

Signed-off-by: Uilian Ries <[email protected]>
* #354 Add CONAN_CONANFILE option

Signed-off-by: Uilian Ries <[email protected]>

* #354 Add option description on README

Signed-off-by: Uilian Ries <[email protected]>

* #354 Support CONAN_CONANFILE option

- Add full support for custom conanfile name
- Add tests

Signed-off-by: Uilian Ries <[email protected]>

* #354 Fix boolean option

Signed-off-by: Uilian Ries <[email protected]>
- Parse the env var CONAN_SKIP_CHECK_CREDENTIALS as boolean

Signed-off-by: Uilian Ries <[email protected]>
use variable BUILD_SOURCEBRANCH
BUILD_SOURCEBRANCHNAME only has the part after last /
* #153 Upload only the recipe

- Add CONAN_UPLOAD_ONLY_RECIPE env var, which set to skip
  all binary packages upload.

Signed-off-by: Uilian Ries <[email protected]>

* #153 Test upload only the recipe

- get boolean value from environment variable is non-case sensitive now

Signed-off-by: Uilian Ries <[email protected]>

* #153 Fix upload recipe argument

@madebr found a bug where the argument is wrong.

Co-Authored-By: uilianries <[email protected]>

* #153 Fix unit test for upload recipe

Signed-off-by: Uilian Ries <[email protected]>

* #153 Add test to check parameters

Signed-off-by: Uilian Ries <[email protected]>

* #153 Fix conflict in README file
- Use custom Docker network instead of using custom cache.

Signed-off-by: Uilian Ries <[email protected]>
allow passing user-specified Docker args during create step
@lasote lasote changed the base branch from develop to master March 28, 2019 13:38
lasote and others added 5 commits March 28, 2019 14:40
- Tox 3.8.1 is totally broken

Signed-off-by: Uilian Ries <[email protected]>
* #361 Upload package with revisions

- Package reference passed to be created is not the same
  retrieved from package id when the package is built.
  "foo/0.1@bar/testing" != "foo/0.1@bar/testing#<hash>"

Signed-off-by: Uilian Ries <[email protected]>

* #361 Parse revision

Signed-off-by: Uilian Ries <[email protected]>
* Fix broken tests for release 0.25.0

- Release branch is fragile, only specific tests are able to run,
  or even CPT behavior could change during the tests.

Signed-off-by: Uilian Ries <[email protected]>

* Run Docker test as regular test

- Do not require Bintray account to run docker tests

Signed-off-by: Uilian Ries <[email protected]>
@codecov-io
Copy link

codecov-io commented Mar 29, 2019

Codecov Report

Merging #362 into master will increase coverage by 1.91%.
The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
+ Coverage   90.45%   92.36%   +1.91%     
==========================================
  Files          32       32              
  Lines        2775     3011     +236     
==========================================
+ Hits         2510     2781     +271     
+ Misses        265      230      -35
Impacted Files Coverage Δ
cpt/run_in_docker.py 0% <0%> (ø) ⬆️
cpt/uploader.py 88.23% <100%> (+2.02%) ⬆️
cpt/tools.py 80% <100%> (ø) ⬆️
cpt/test/unit/utils.py 96.42% <100%> (+1.3%) ⬆️
cpt/test/unit/ci_manager_test.py 100% <100%> (ø) ⬆️
cpt/__init__.py 100% <100%> (ø) ⬆️
cpt/test/integration/upload_test.py 92.2% <100%> (+0.1%) ⬆️
cpt/test/integration/docker_test.py 86.3% <100%> (+58.23%) ⬆️
cpt/test/integration/basic_test.py 94.89% <100%> (+0.78%) ⬆️
cpt/ci_manager.py 93.45% <100%> (+0.09%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46b6e77...6a90c75. Read the comment docs.

@lasote lasote merged commit 444a6d9 into master Mar 29, 2019
@lasote lasote deleted the release/0.25.0 branch March 29, 2019 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants