Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload package dependencies #334

Merged
merged 8 commits into from
Mar 19, 2019
Merged

Upload package dependencies #334

merged 8 commits into from
Mar 19, 2019

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Feb 6, 2019 •
edited
Loading

Hi!

Changelog: Feature: Upload built missing dependencies (#237)

  • Add the option CONAN_UPLOAD_DEPENDENCIES
  • Upload ALL dependencies when CONAN_UPLOAD_DEPENDENCIES == "all"
  • Upload only specific dependency when CONAN_UPLOAD_DEPENDENCIES == <package_ref>
  • It does not accept wildcard like "foo/*"
  • It raises an error when both "all" and <package_ref> are listed. XOR case.

fixes #237

@uilianries
conan-io#237 Update README
9b54b8f 
- Add description about the new feature

Signed-off-by: Uilian Ries <[email protected]>
@uilianries uilianries self-assigned this Feb 6, 2019
@uilianries uilianries changed the title [WIP] Upload package dependencies Upload package dependencies Mar 9, 2019
@uilianries
conan-io#237 Fix env var name
fac9945 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries uilianries requested a review from lasote March 9, 2019 20:33
@Linux13524
Copy link

Hi. The check if the dependency has been built is missing. So all dependencies will be uploaded. Is this intentional?

Linux13524
Linux13524 reviewed Mar 10, 2019
View reviewed changes
cpt/runner.py Outdated Show resolved Hide resolved
@uilianries
Copy link
Member Author

Hi. The check if the dependency has been built is missing. So all dependencies will be uploaded. Is this intentional?

No, thinking again you are right. Since #237 is about build policy missing, so only built package should be uploaded. I gonna update this. Thanks for reviewing.

@lasote lasote added this to the 0.25.0 milestone Mar 15, 2019
@settings settings bot removed the enhancement label Mar 15, 2019
@uilianries uilianries assigned lasote and unassigned uilianries Mar 15, 2019
@lasote lasote merged commit fd3806e into conan-io:develop Mar 19, 2019
lasote added a commit that referenced this pull request Mar 29, 2019
@lasote
0.25.0 (#362)
444a6d9 
* allow passing user-specified Docker args during create step

* rename parameter

* mention CONAN_DOCKER_RUN_OPTIONS envvar in readme

* add tests

* #343 Improve docker integration test

- Fix conan_pip_package. It should be a str by default
- Pass original printer to be re-used by Docker runner
- Add integration test to validate docker run options

Signed-off-by: Uilian Ries <[email protected]>

* #343 Fix skip test when running docker

Signed-off-by: Uilian Ries <[email protected]>

* Add GitHub settings (#345) (#349)

* Add GitHub settings

- Use standard Conan tags for issues
- Add stale config for timeout bot
- Add issue template

Signed-off-by: Uilian Ries <[email protected]>

* Use Github settings from conanio/docs

Signed-off-by: Uilian Ries <[email protected]>

* #345 Add PR template

- Add PR template to generate the changelog
- Add the contributing guide

Signed-off-by: Uilian Ries <[email protected]>

* Trigger Github Settings (#352)

Signed-off-by: Uilian Ries <[email protected]>

* #336 Forward login method (#344)

Signed-off-by: Uilian Ries <[email protected]>

* Upload package dependencies (#334)

* #237 Update README

- Add description about the new feature

Signed-off-by: Uilian Ries <[email protected]>

* #237 Upload all dependencies

Signed-off-by: Uilian Ries <[email protected]>

* #237 Unit test to upload all deps

Signed-off-by: Uilian Ries <[email protected]>

* #237 Fix env var name

Signed-off-by: Uilian Ries <[email protected]>

* #237 Fix upload dependencies

Signed-off-by: Uilian Ries <[email protected]>

* #237 Upload only built packages

Signed-off-by: Uilian Ries <[email protected]>

* #237 Only upload when package is available

Signed-off-by: Uilian Ries <[email protected]>

* Accept custom pip command (#347)

* #147 Support custom PIP command

- Add env var CONAN_PIP_COMMAND which allows to run a specific
  pip version, or even a pip binary path.

Signed-off-by: Uilian Ries <[email protected]>

* #147 Check pip command before to run

- To avoid command injection, the custom pip command will be checked

Signed-off-by: Uilian Ries <[email protected]>

* #147 Test dynamic pip version

- Check for current pip version before to customize CONAN_PIP_COMMAND

Signed-off-by: Uilian Ries <[email protected]>

* #147 Ignore which pip on Windows

Signed-off-by: Uilian Ries <[email protected]>

* #147 pip install quiet mode

Signed-off-by: Uilian Ries <[email protected]>

* #147 Try to fix Windows tests

Signed-off-by: Uilian Ries <[email protected]>

* #277 Accept Docker arguments as list

- both string and list are accepted as docker arguments
- Update docker test to use list

Signed-off-by: Uilian Ries <[email protected]>

* #277 Fix options when downloading docker image

- Docker is executed in two cases. The first one is when
  we need to download the docker image and patch with the
  newest Conan version. The options were skipped there

Signed-off-by: Uilian Ries <[email protected]>

* #354 Add CONAN_CONANFILE option (#357)

* #354 Add CONAN_CONANFILE option

Signed-off-by: Uilian Ries <[email protected]>

* #354 Add option description on README

Signed-off-by: Uilian Ries <[email protected]>

* #354 Support CONAN_CONANFILE option

- Add full support for custom conanfile name
- Add tests

Signed-off-by: Uilian Ries <[email protected]>

* #354 Fix boolean option

Signed-off-by: Uilian Ries <[email protected]>

* #355 Skip check credentials is boolean (#356)

- Parse the env var CONAN_SKIP_CHECK_CREDENTIALS as boolean

Signed-off-by: Uilian Ries <[email protected]>

* fix azure pipelines branch detection (#346)

use variable BUILD_SOURCEBRANCH
BUILD_SOURCEBRANCHNAME only has the part after last /

* Feature/upload only recipe (#348)

* #153 Upload only the recipe

- Add CONAN_UPLOAD_ONLY_RECIPE env var, which set to skip
  all binary packages upload.

Signed-off-by: Uilian Ries <[email protected]>

* #153 Test upload only the recipe

- get boolean value from environment variable is non-case sensitive now

Signed-off-by: Uilian Ries <[email protected]>

* #153 Fix upload recipe argument

@madebr found a bug where the argument is wrong.

Co-Authored-By: uilianries <[email protected]>

* #153 Fix unit test for upload recipe

Signed-off-by: Uilian Ries <[email protected]>

* #153 Add test to check parameters

Signed-off-by: Uilian Ries <[email protected]>

* #153 Fix conflict in README file

* Update Docker run example

- Use custom Docker network instead of using custom cache.

Signed-off-by: Uilian Ries <[email protected]>

* Prepared for 1.15

* 0.25.0

* 1.15.0

* Fix Tox version (#364)

- Tox 3.8.1 is totally broken

Signed-off-by: Uilian Ries <[email protected]>

* #361 Upload package with revisions (#363)

* #361 Upload package with revisions

- Package reference passed to be created is not the same
  retrieved from package id when the package is built.
  "foo/0.1@bar/testing" != "foo/0.1@bar/testing#<hash>"

Signed-off-by: Uilian Ries <[email protected]>

* #361 Parse revision

Signed-off-by: Uilian Ries <[email protected]>

* Fix broken tests for release 0.25.0 (#365)

* Fix broken tests for release 0.25.0

- Release branch is fragile, only specific tests are able to run,
  or even CPT behavior could change during the tests.

Signed-off-by: Uilian Ries <[email protected]>

* Run Docker test as regular test

- Do not require Bintray account to run docker tests

Signed-off-by: Uilian Ries <[email protected]>

* Clean some stuff and improve test running in local
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Linux13524 Linux13524 Linux13524 left review comments

@lasote lasote Awaiting requested review from lasote

Assignees

@lasote lasote

Labels
None yet
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

How to upload build dependencies too?
3 participants
@uilianries @Linux13524 @lasote