netcdf: add netcdf/4.7.4 recipe #3350

madebr · 2020-10-29T20:18:39Z

Specify library name and version: netcdf/4.7.4

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

conan-center-bot · 2020-10-29T20:31:30Z

Some configurations of 'netcdf/4.7.4' failed in build 1 (dbbb80c04124dc2cc788b1acf4232ca07bf6497a):

Linux x86_64, Debug, gcc 4.9, libstdc++ . Options: netcdf:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs
Macos x86_64, Release, apple-clang 9.1, libc++ . Options: netcdf:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs
Windows x86_64, Release, Visual Studio 16, MT. Options: netcdf:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Windows x86_64, Debug, Visual Studio 16, MTd. Options: netcdf:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MT. Options: netcdf:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MD. Options: netcdf:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Windows x86_64, Release, Visual Studio 16, MD. Options: netcdf:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MTd. Options: netcdf:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Windows x86_64, Release, Visual Studio 14, MT. Options: netcdf:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Windows x86_64, Release, Visual Studio 14, MD. Options: netcdf:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Windows x86_64, Debug, Visual Studio 14, MDd. Options: netcdf:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Windows x86_64, Debug, Visual Studio 14, MTd. Options: netcdf:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, gcc 8, libstdc++11 . Options: netcdf:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs

…ll's

conan-center-bot · 2020-10-31T23:15:30Z

Some configurations of 'netcdf/4.7.4' failed in build 2 (ae5c56b3dfaa2dfc0d32d5af3db2b27ac34a8637):

Macos x86_64, Debug, apple-clang 9.1, libc++ . Options: netcdf:shared-True
Access to all the logs
Linux x86_64, Debug, gcc 5, libstdc++11 . Options: netcdf:shared-True
Access to all the logs
Linux x86_64, Debug, gcc 8, libstdc++11 . Options: netcdf:shared-True
Access to all the logs

ghost · 2020-11-16T08:54:31Z

I detected other pull requests that are modifying netcdf/all recipe:

new package: netcdf 4.7.4 #2060

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

conan-center-bot · 2020-11-27T01:14:28Z

All green in build 3 (7cdcb83261d0d0b37e18d912d0b0b878f3dd2d55)! 😊

netcdf/4.7.4: Generated 88 packages. All logs here

recipes/netcdf/all/conanfile.py

Co-authored-by: Uilian Ries <[email protected]>

conan-center-bot · 2020-11-27T19:14:00Z

All green in build 4 (faadb260a00e84790bf5fa8d9e28edd5ff875141)! 😊

netcdf/4.7.4: Generated 88 packages. All logs here

recipes/netcdf/all/conanfile.py

prince-chrismc · 2021-01-04T17:20:41Z

Please retrigger CI =)

madebr · 2021-01-04T17:37:33Z

@prince-chrismc
Thanks for the reminder

conan-center-bot · 2021-01-04T18:18:13Z

All green in build 6 (80e653ef483408391e2fc0176cd9ba5c296df0ee)! 😊

netcdf/4.7.4: Generated 88 packages. All logs here

uilianries

LGTM

SSE4 · 2021-01-07T10:28:19Z

recipes/netcdf/all/conanfile.py

+        "cdf5": True,
+        "dap": True,
+    }
+    generators = "cmake_find_package", "cmake_find_package_multi", "cmake"


I rarely see both cmake_find_package and cmake_find_package_multi are needed

SSE4 · 2021-01-07T10:28:47Z

recipes/netcdf/all/patches/0001-cmake-subproject.patch

+      file(RELATIVE_PATH __makedist_cur_path "${PROJECT_SOURCE_DIR}" "${__makedist_full_cur_path}")
+     elseif(__makedist_extradist)
+-      file(RELATIVE_PATH __makedist_cur_path "${CMAKE_BINARY_DIR}" "${__makedist_full_cur_path}")
+      file(RELATIVE_PATH __makedist_cur_path "${PROJCT_BINARY_DIR}" "${__makedist_full_cur_path}")


Suggested change

+ file(RELATIVE_PATH __makedist_cur_path "${PROJCT_BINARY_DIR}" "${__makedist_full_cur_path}")

+ file(RELATIVE_PATH __makedist_cur_path "${PROJECT_BINARY_DIR}" "${__makedist_full_cur_path}")

Croydon · 2021-01-07T11:22:28Z

Oh damn. While going through issues I noticed this comment: #1850 (comment)

This probably should have been named netcdf-c instead. netcdf-cxx also exists.

d70-t · 2021-01-07T12:10:42Z

Thank you all for finishing the netcdf recipe! I got sidetracked with my PR and am very happy that I don't have to worry about it anymore. 👍 💯

netcdf: add netcdf/4.7.4 recipe

dbbb80c

conan-center-bot added the Failed label Oct 29, 2020

netcdf: patch find_package(HDF5) for MSVC + remove installed msvcrt d…

ae5c56b

…ll's

ericLemanissier mentioned this pull request Nov 12, 2020

[service] Potentially conflicting recipes #3517

Closed

ghost mentioned this pull request Nov 16, 2020

[service] Potentially conflicting recipes #3571

Closed

ghost mentioned this pull request Nov 16, 2020

new package: netcdf 4.7.4 #2060

Closed

4 tasks

netcdf: fix shared Debug on Linux

7cdcb83

conan-center-bot removed the Failed label Nov 27, 2020

uilianries reviewed Nov 27, 2020

View reviewed changes

recipes/netcdf/all/conanfile.py Outdated Show resolved Hide resolved

recipes/netcdf/all/conanfile.py Outdated Show resolved Hide resolved

netcdf: fix license + topics

faadb26

Co-authored-by: Uilian Ries <[email protected]>

prince-chrismc reviewed Dec 2, 2020

View reviewed changes

recipes/netcdf/all/conanfile.py Outdated Show resolved Hide resolved

madebr commented Dec 2, 2020

View reviewed changes

recipes/netcdf/all/conanfile.py Outdated Show resolved Hide resolved

netcdf: remove unused build_requirements

80e653e

prince-chrismc approved these changes Dec 3, 2020

View reviewed changes

github-actions bot mentioned this pull request Dec 26, 2020

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

uilianries approved these changes Jan 4, 2021

View reviewed changes

SSE4 reviewed Jan 7, 2021

View reviewed changes

SSE4 approved these changes Jan 7, 2021

View reviewed changes

conan-center-bot merged commit 04873b0 into conan-io:master Jan 7, 2021

Croydon mentioned this pull request Jan 7, 2021

[request] netcdf-c/4.7.4 #1850

Closed

madebr deleted the netcdf_recipe branch January 7, 2021 15:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

netcdf: add netcdf/4.7.4 recipe #3350

netcdf: add netcdf/4.7.4 recipe #3350

madebr commented Oct 29, 2020 •

edited

Loading

conan-center-bot commented Oct 29, 2020

conan-center-bot commented Oct 31, 2020

ghost commented Nov 16, 2020 •

edited by ghost

Loading

conan-center-bot commented Nov 27, 2020

conan-center-bot commented Nov 27, 2020

prince-chrismc commented Jan 4, 2021

madebr commented Jan 4, 2021

conan-center-bot commented Jan 4, 2021

uilianries left a comment

SSE4 Jan 7, 2021

SSE4 Jan 7, 2021

Croydon commented Jan 7, 2021 •

edited

Loading

d70-t commented Jan 7, 2021

	+ file(RELATIVE_PATH __makedist_cur_path "${PROJCT_BINARY_DIR}" "${__makedist_full_cur_path}")
	+ file(RELATIVE_PATH __makedist_cur_path "${PROJECT_BINARY_DIR}" "${__makedist_full_cur_path}")

netcdf: add netcdf/4.7.4 recipe #3350

netcdf: add netcdf/4.7.4 recipe #3350

Conversation

madebr commented Oct 29, 2020 • edited Loading

conan-center-bot commented Oct 29, 2020

conan-center-bot commented Oct 31, 2020

ghost commented Nov 16, 2020 • edited by ghost Loading

conan-center-bot commented Nov 27, 2020

conan-center-bot commented Nov 27, 2020

prince-chrismc commented Jan 4, 2021

madebr commented Jan 4, 2021

conan-center-bot commented Jan 4, 2021

uilianries left a comment

Choose a reason for hiding this comment

SSE4 Jan 7, 2021

Choose a reason for hiding this comment

SSE4 Jan 7, 2021

Choose a reason for hiding this comment

Croydon commented Jan 7, 2021 • edited Loading

d70-t commented Jan 7, 2021

madebr commented Oct 29, 2020 •

edited

Loading

ghost commented Nov 16, 2020 •

edited by ghost

Loading

Croydon commented Jan 7, 2021 •

edited

Loading