new package: netcdf 4.7.4 #2060

d70-t · 2020-06-26T15:19:29Z

Specify library name and version: libnetcdf/4.7

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

conan-center-bot · 2020-06-26T15:19:55Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

recipes/netcdf/all/conanfile.py

recipes/netcdf/all/test_package/conanfile.py

recipes/netcdf/all/conanfile.py

recipes/netcdf/all/conandata.yml

Co-authored-by: Uilian Ries <[email protected]>

conan-center-bot · 2020-06-27T17:13:31Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-06-27T17:13:40Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

Co-authored-by: Uilian Ries <[email protected]>

conan-center-bot · 2020-06-27T17:15:24Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-06-27T17:16:02Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-06-27T17:17:52Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

Co-authored-by: Uilian Ries <[email protected]>

conan-center-bot · 2020-06-27T17:39:49Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-06-27T17:43:43Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

d70-t · 2020-06-27T17:52:51Z

@uilianries thank you for the review. I think I have updated the PR according to your comments now.

recipes/netcdf/all/test_package/CMakeLists.txt

Co-authored-by: Uilian Ries <[email protected]>

conan-center-bot · 2020-06-29T19:35:47Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

uilianries

Almost good!

recipes/netcdf/all/conanfile.py

Co-authored-by: Uilian Ries <[email protected]>

conan-center-bot · 2020-06-30T15:01:23Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2020-07-01T11:28:23Z

Some configurations of 'netcdf/4.7.4' failed in build 11 (d5f7120b848182dc611fd41f5511314fb7a340d3):

Windows x86_64, Debug, Visual Studio 14, MTd. Options: netcdf:shared-False
Access to all the logs

d70-t · 2020-07-01T12:14:11Z

Hmm, seems that Autotools don't play so well with Windows. There is the possibility to compile netcdf using CMake. I think I'll try that in stead. But I don't have any windows machines available here to test it locally.

conan-center-bot · 2020-07-01T12:57:59Z

Some configurations of 'netcdf/4.7.4' failed in build 12 (0ad1a39cf182056a6257744de602a2c4658e5528):

Linux x86_64, Release, gcc 5, libstdc++ . Options: netcdf:shared-True
Access to all the logs

conan-center-bot · 2020-07-01T22:16:15Z

Some configurations of 'netcdf/4.7.4' failed in build 13 (023703c8fc37d220b657417fc023105897a1244d):

Windows x86_64, Debug, Visual Studio 14, MTd. Options: netcdf:shared-False
- Hooks errors detected:
  - [HOOK - conan-center.py] post_package(): ERROR: [MS RUNTIME FILES (KB-H021)] The conan-center repository doesn't allow Microsoft Visual Studio runtime files. (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H021)
  - [HOOK - conan-center.py] post_package(): ERROR: [MS RUNTIME FILES (KB-H021)] Found files:
- Log download
- Log error Download
- Profile
Access to all the logs

The netCDF CMake build system does not use find_package in a way which is compatible to conan, so a couple of patches have been required to get the build running.

conan-center-bot · 2020-07-01T22:40:44Z

Some configurations of 'netcdf/4.7.4' failed in build 14 (3bcf852b0381218fa4b0bbec4428310ecd741747):

Windows x86_64, Debug, Visual Studio 14, MTd. Options: netcdf:shared-False
Access to all the logs

d70-t · 2020-07-01T22:57:02Z

This seems to be an error while building the test_package. I've added the (maybe) relevant section from the logs below.
To me, the test_package does not look very complicated and seems to be alright. I also tested several combinations of options under a fresh Linux image and did not have problems any more.
However I have not much experience in building things on Windows and also no machine available to run the build alone.
Do you have any thoughts about what might be the cause of this error?

netcdf/4.7.4 (test package): Calling build()

----Running------
> cd C:\J\workspace\onan-center-pull-request_PR-2060/14/co_pr_2060_14_0_2/recipes/netcdf/all\test_package\build\26d79e4212ff67274e14435b85e9736506988934 && cmake -G "Visual Studio 14 2015 Win64" -DCONAN_LINK_RUNTIME="/MTd" -DCONAN_IN_LOCAL_CACHE="OFF" -DCONAN_COMPILER="Visual Studio" -DCONAN_COMPILER_VERSION="14" -DCONAN_CXX_FLAGS="/MP1" -DCONAN_C_FLAGS="/MP1" -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY="ON" -DCONAN_EXPORTED="1" -Wno-dev C:\J\workspace\onan-center-pull-request_PR-2060/14/co_pr_2060_14_0_2/recipes/netcdf/all\test_package
-----------------
-- Selecting Windows SDK version 10.0.14393.0 to target Windows 10.0.17763.
-- The C compiler identification is MSVC 19.0.24215.1
-- The CXX compiler identification is MSVC 19.0.24215.1
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Conan: called by CMake conan helper
-- Conan: Adjusting output directories
-- Conan: Using cmake targets configuration
-- Library netcdf found C:/J/workspace/onan-center-pull-request_PR-2060/14/pr_2060_14_0_2/.conan/data/netcdf/4.7.4/_/_/package/0f5db2d969f1a4f790c8f8646e5d9a62fb1e5705/lib/netcdf.lib
-- Library libhdf5_hl_cpp_D found C:/J/workspace/onan-center-pull-request_PR-2060/14/pr_2060_14_0_2/.conan/data/hdf5/1.12.0/_/_/package/37b1bda3ad7648f50db885a507b76e125a83c955/lib/libhdf5_hl_cpp_D.lib
-- Library libhdf5_hl_D found C:/J/workspace/onan-center-pull-request_PR-2060/14/pr_2060_14_0_2/.conan/data/hdf5/1.12.0/_/_/package/37b1bda3ad7648f50db885a507b76e125a83c955/lib/libhdf5_hl_D.lib
-- Library libhdf5_cpp_D found C:/J/workspace/onan-center-pull-request_PR-2060/14/pr_2060_14_0_2/.conan/data/hdf5/1.12.0/_/_/package/37b1bda3ad7648f50db885a507b76e125a83c955/lib/libhdf5_cpp_D.lib
-- Library libhdf5_D found C:/J/workspace/onan-center-pull-request_PR-2060/14/pr_2060_14_0_2/.conan/data/hdf5/1.12.0/_/_/package/37b1bda3ad7648f50db885a507b76e125a83c955/lib/libhdf5_D.lib
-- Library libcurl found C:/J/workspace/onan-center-pull-request_PR-2060/14/pr_2060_14_0_2/.conan/data/libcurl/7.70.0/_/_/package/a4abe4fc757dbe018c6fe482515019419f706128/lib/libcurl.lib
-- Library zlib found C:/J/workspace/onan-center-pull-request_PR-2060/14/pr_2060_14_0_2/.conan/data/zlib/1.2.11/_/_/package/f27dcd2d5e453cb01f9324a959461903ce8116a0/lib/zlib.lib
-- Library libssld found C:/J/workspace/onan-center-pull-request_PR-2060/14/pr_2060_14_0_2/.conan/data/openssl/1.1.1g/_/_/package/f27dcd2d5e453cb01f9324a959461903ce8116a0/lib/libssld.lib
-- Library libcryptod found C:/J/workspace/onan-center-pull-request_PR-2060/14/pr_2060_14_0_2/.conan/data/openssl/1.1.1g/_/_/package/f27dcd2d5e453cb01f9324a959461903ce8116a0/lib/libcryptod.lib
-- Conan: Adjusting default RPATHs Conan policies
-- Conan: Adjusting language standard
-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_EXPORT_NO_PACKAGE_REGISTRY


-- Build files have been written to: C:/J/workspace/onan-center-pull-request_PR-2060/14/co_pr_2060_14_0_2/recipes/netcdf/all/test_package/build/26d79e4212ff67274e14435b85e9736506988934

----Running------
> cmake --build C:\J\workspace\onan-center-pull-request_PR-2060/14/co_pr_2060_14_0_2/recipes/netcdf/all\test_package\build\26d79e4212ff67274e14435b85e9736506988934 --config Debug -- /m:1 /verbosity:minimal
-----------------
Microsoft (R) Build Engine version 14.0.25420.1


Copyright (C) Microsoft Corporation. All rights reserved.





  Checking Build System


  Building Custom Rule C:/J/workspace/onan-center-pull-request_PR-2060/14/co_pr_2060_14_0_2/recipes/netcdf/all/test_package/CMakeLists.txt


  example.c


LINK : warning LNK4098: defaultlib 'MSVCRTD' conflicts with use of other libs; use /NODEFAULTLIB:library [C:\J\workspace\onan-center-pull-request_PR-2060\14\co_pr_2060_14_0_2\recipes\netcdf\all\test_package\build\26d79e4212ff67274e14435b85e9736506988934\example.vcxproj]


netcdf.lib(derror.obj) : error LNK2019: unresolved external symbol __imp_strerror referenced in function nc_strerror [C:\J\workspace\onan-center-pull-request_PR-2060\14\co_pr_2060_14_0_2\recipes\netcdf\all\test_package\build\26d79e4212ff67274e14435b85e9736506988934\example.vcxproj]


C:\J\workspace\onan-center-pull-request_PR-2060\14\co_pr_2060_14_0_2\recipes\netcdf\all\test_package\build\26d79e4212ff67274e14435b85e9736506988934\bin\example.exe : fatal error LNK1120: 1 unresolved externals [C:\J\workspace\onan-center-pull-request_PR-2060\14\co_pr_2060_14_0_2\recipes\netcdf\all\test_package\build\26d79e4212ff67274e14435b85e9736506988934\example.vcxproj]

uilianries · 2020-07-02T13:55:03Z

@d70-t You can

conan-center-index/recipes/univalue/all/conanfile.py

Line 75 in aab7ce2

"CC": "cl -nologo",

for Autotols + Windows.

SpaceIm · 2020-07-03T15:08:36Z

I have a draft of netcdf-c recipe using CMake, and also with hdf4 support: https://github.com/SpaceIm/conan-netcdf-c/blob/testing/4.7.4/conanfile.py

d70-t · 2020-07-24T14:23:30Z

Sorry for being off track for a while. I was moving to a different city.

@SpaceIm that looks great! What do you think would be a good way forward? I think building with CMake is actually the better choice, and I see that you did the same. I also see that you seem to have covered a lot more features and I don't really know how to effectively resolve the windows issues. Is there a point in merging your and my recipe? Or would it be better to just continue with yours?

SpaceIm · 2020-07-24T14:38:56Z

Feel free to reuse my repo in this PR if you want. As far as I remember, it still requires some tricks to properly inject dependencies in netcdf cmake files.

This approach is also present in netcdf's own tests.

SpaceIm · 2020-09-19T21:23:27Z

@d70-t please consider d70-t#1

Sorry if it brutally changes some file/options names or order of functions, I've copied/pasted files of my netcdf recipe at https://github.com/SpaceIm/conan-netcdf-c

So far, it works except if hdf4 is enabled (ODR violation between netcdf-c and a lib from hdf4, very weird). Some checks in hdf5 (made in CMakeLists) could be improved.

ghost · 2020-11-16T08:54:33Z

I detected other pull requests that are modifying netcdf/all recipe:

netcdf: add netcdf/4.7.4 recipe #3350

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

stale · 2020-12-17T17:10:57Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Croydon · 2021-01-07T11:25:46Z

Can be closed as #3350 is merged now

new package: netcdf 4.7.0 ... 4.7.4

36a7720

conan-center-bot added the No Beta user label Jun 26, 2020

uilianries requested changes Jun 26, 2020

View reviewed changes

uilianries reviewed Jun 26, 2020

View reviewed changes

recipes/netcdf/all/conandata.yml Outdated Show resolved Hide resolved

d70-t and others added 2 commits June 27, 2020 19:12

netcdf: use get_safe to read fPIC option

92a30cd

Co-authored-by: Uilian Ries <[email protected]>

netcdf: remove superfluous library configuration

b45787a

Co-authored-by: Uilian Ries <[email protected]>

netcdf: show info message when appending to PATH env var

4d4235a

Co-authored-by: Uilian Ries <[email protected]>

d70-t and others added 5 commits June 27, 2020 19:35

netcdf/test_package: only run example if not cross building

bbe9b3f

Co-authored-by: Uilian Ries <[email protected]>

netcdf: remove useless fPIC option when building shared

ed60ce7

Co-authored-by: Uilian Ries <[email protected]>

netcdf: use fixed versions for dependencies

4dd6521

netcdf: cache autotools when using it for building and packaging

2e23476

netcdf: fix error when building without dap

94857ce

d70-t force-pushed the netcdf branch from d245c4b to 6915de5 Compare June 27, 2020 17:39

netcdf: removed old versions

e2b236f

d70-t force-pushed the netcdf branch from 6915de5 to e2b236f Compare June 27, 2020 17:43

d70-t changed the title ~~new package: netcdf 4.7.0 ... 4.7.4~~ new package: netcdf 4.7.4 Jun 27, 2020

d70-t mentioned this pull request Jun 27, 2020

[request] netcdf-c/4.7.4 #1850

Closed

uilianries requested changes Jun 29, 2020

View reviewed changes

recipes/netcdf/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved

netcdf: require CMake 3.1 to be able to use TARGETS

f0f72e5

Co-authored-by: Uilian Ries <[email protected]>

uilianries approved these changes Jun 30, 2020

View reviewed changes

recipes/netcdf/all/conanfile.py Show resolved Hide resolved

netcdf: remove unused code

d5f7120

Co-authored-by: Uilian Ries <[email protected]>

danimtb removed the No Beta user label Jul 1, 2020

conan-center-bot added the Failed label Jul 1, 2020

netcdf: converted to CMake build

0ad1a39

d70-t added 2 commits July 2, 2020 00:22

netcdf: apply patches to build system

4ee187a

The netCDF CMake build system does not use find_package in a way which is compatible to conan, so a couple of patches have been required to get the build running.

netcdf: remove MS runtime files

3bcf852

d70-t force-pushed the netcdf branch from 023703c to 3bcf852 Compare July 1, 2020 22:23

d70-t added 2 commits September 1, 2020 16:20

netcdf/Windows: use crt library depending on cofigured runtime

4427656

netcdf/Windows: use /NODEFAULTLIB:MSVCRT for test_package

0b3e7fd

This approach is also present in netcdf's own tests.

ericLemanissier mentioned this pull request Nov 12, 2020

[service] Potentially conflicting recipes #3517

Closed

This was referenced Nov 16, 2020

[service] Potentially conflicting recipes #3571

Closed

netcdf: add netcdf/4.7.4 recipe #3350

Merged

stale bot added the stale label Dec 17, 2020

stale bot removed the stale label Jan 7, 2021

SSE4 closed this Jan 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new package: netcdf 4.7.4 #2060

new package: netcdf 4.7.4 #2060

d70-t commented Jun 26, 2020

conan-center-bot commented Jun 26, 2020

conan-center-bot commented Jun 27, 2020

conan-center-bot commented Jun 27, 2020

conan-center-bot commented Jun 27, 2020

conan-center-bot commented Jun 27, 2020

conan-center-bot commented Jun 27, 2020

conan-center-bot commented Jun 27, 2020

conan-center-bot commented Jun 27, 2020

d70-t commented Jun 27, 2020

conan-center-bot commented Jun 29, 2020

uilianries left a comment

conan-center-bot commented Jun 30, 2020

conan-center-bot commented Jul 1, 2020

d70-t commented Jul 1, 2020

conan-center-bot commented Jul 1, 2020

conan-center-bot commented Jul 1, 2020

conan-center-bot commented Jul 1, 2020

d70-t commented Jul 1, 2020

uilianries commented Jul 2, 2020

SpaceIm commented Jul 3, 2020

d70-t commented Jul 24, 2020

SpaceIm commented Jul 24, 2020

SpaceIm commented Sep 19, 2020 •

edited

Loading

ghost commented Nov 16, 2020 •

edited by ghost

Loading

stale bot commented Dec 17, 2020

Croydon commented Jan 7, 2021

new package: netcdf 4.7.4 #2060

new package: netcdf 4.7.4 #2060

Conversation

d70-t commented Jun 26, 2020

conan-center-bot commented Jun 26, 2020

conan-center-bot commented Jun 27, 2020

conan-center-bot commented Jun 27, 2020

conan-center-bot commented Jun 27, 2020

conan-center-bot commented Jun 27, 2020

conan-center-bot commented Jun 27, 2020

conan-center-bot commented Jun 27, 2020

conan-center-bot commented Jun 27, 2020

d70-t commented Jun 27, 2020

conan-center-bot commented Jun 29, 2020

uilianries left a comment

Choose a reason for hiding this comment

conan-center-bot commented Jun 30, 2020

conan-center-bot commented Jul 1, 2020

d70-t commented Jul 1, 2020

conan-center-bot commented Jul 1, 2020

conan-center-bot commented Jul 1, 2020

conan-center-bot commented Jul 1, 2020

d70-t commented Jul 1, 2020

uilianries commented Jul 2, 2020

SpaceIm commented Jul 3, 2020

d70-t commented Jul 24, 2020

SpaceIm commented Jul 24, 2020

SpaceIm commented Sep 19, 2020 • edited Loading

ghost commented Nov 16, 2020 • edited by ghost Loading

stale bot commented Dec 17, 2020

Croydon commented Jan 7, 2021

SpaceIm commented Sep 19, 2020 •

edited

Loading

ghost commented Nov 16, 2020 •

edited by ghost

Loading