Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open62541 - Allow more clang versions #20892

Merged
merged 24 commits into from
Nov 27, 2023
Merged

Open62541 - Allow more clang versions #20892

merged 24 commits into from
Nov 27, 2023

Conversation

Kischy
Copy link
Contributor

@Kischy Kischy commented Nov 2, 2023

Specify library name and version: open62541/1.3.8

Allows a broader variety of clang compiler versions. See issue #20579


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@Kischy Kischy changed the title Open62541 - Allow clang for versions >= 1.3.8 Open62541 - Allow more clang for versions >= 1.3.8 Nov 9, 2023
@Kischy Kischy changed the title Open62541 - Allow more clang for versions >= 1.3.8 Open62541 - Allow more clang versions for Open62541 versions >= 1.3.8 Nov 9, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

recipes/open62541/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Nov 15, 2023
@Kischy
Copy link
Contributor Author

Kischy commented Nov 16, 2023

@Ahajha Will this be squash merged? The history is not needed imho.

@Ahajha
Copy link
Contributor

Ahajha commented Nov 16, 2023

@Ahajha Will this be squash merged? The history is not needed imho.

Yes, the commits are squashed.

@conan-center-bot

This comment has been minimized.

@Kischy
Copy link
Contributor Author

Kischy commented Nov 20, 2023

@Ahajha Who do I need to ask for a second review?

@Ahajha
Copy link
Contributor

Ahajha commented Nov 20, 2023

@Ahajha Who do I need to ask for a second review?

Hopefully Ruben will get to it soon, I think he's been a bit busy recently. Also my approval "doesn't count" so to speak, I don't have write access.

@Kischy
Copy link
Contributor Author

Kischy commented Nov 20, 2023

@Ahajha Who do I need to ask for a second review?

Hopefully Ruben will get to it soon, I think he's been a bit busy recently. Also my approval "doesn't count" so to speak, I don't have write access.

Ok, so I still need a second person with write access to review this...

@Kischy
Copy link
Contributor Author

Kischy commented Nov 21, 2023

@Ahajha, @RubenRBS Do you have the possibility to link issue #20579 to this PR? I do not have the rights to do this.

@Kischy
Copy link
Contributor Author

Kischy commented Nov 23, 2023

@RubenRBS Can I help you in any way to get the reviews faster? :)

@Kischy
Copy link
Contributor Author

Kischy commented Nov 24, 2023

@Ahajha Hmm, nothing happening here. How can I motivate someone with write access to review this PR?

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 20 (d8515d7692f569e95857100400c69723cdb06b42):

  • open62541/1.3.8:
    All packages built successfully! (All logs)

  • open62541/1.1.6:
    All packages built successfully! (All logs)

  • open62541/1.2.6:
    All packages built successfully! (All logs)

  • open62541/1.0.6:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 20 (d8515d7692f569e95857100400c69723cdb06b42):

  • open62541/1.0.6:
    All packages built successfully! (All logs)

  • open62541/1.2.6:
    All packages built successfully! (All logs)

  • open62541/1.1.6:
    All packages built successfully! (All logs)

  • open62541/1.3.8:
    All packages built successfully! (All logs)

@Ahajha
Copy link
Contributor

Ahajha commented Nov 24, 2023

@Ahajha Hmm, nothing happening here. How can I motivate someone with write access to review this PR?

Tbh, I wish I knew. I've had a PR sitting for a few weeks now, struggling to get a review myself.

@Kischy
Copy link
Contributor Author

Kischy commented Nov 24, 2023

@Ahajha Hmm, nothing happening here. How can I motivate someone with write access to review this PR?

Tbh, I wish I knew. I've had a PR sitting for a few weeks now, struggling to get a review myself.

Arg... that's depressing. This is blocking other work for me. If this takes so long I will have to find a different solution. 😢

@Kischy
Copy link
Contributor Author

Kischy commented Nov 25, 2023

@Ahajha Which one is your PR? I will try something that might make me quite unpopular...

@Ahajha
Copy link
Contributor

Ahajha commented Nov 25, 2023

Please don't. Regardless, it's a weekend. On Monday I'll try to ask in Slack (Cpplang) for some reviews.

@Kischy
Copy link
Contributor Author

Kischy commented Nov 25, 2023

Please don't. Regardless, it's a weekend. On Monday I'll try to ask in Slack (Cpplang) for some reviews.

Ok , then I wait. Thank you.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your patience, after looking into the initial reasons of why the version limits, this seems to be ok :)

@AbrilRBS
Copy link
Member

Please don't. Regardless, it's a weekend. On Monday I'll try to ask in Slack (Cpplang) for some reviews.

Ok , then I wait. Thank you.

Thank you for your understanding @Kischy @Ahajha

@conan-center-bot conan-center-bot merged commit 2ad6bd0 into conan-io:master Nov 27, 2023
5 checks passed
@Kischy Kischy deleted the open62541/allow_clang branch November 27, 2023 17:56
@Kischy
Copy link
Contributor Author

Kischy commented Nov 27, 2023

@RubenRBS @uilianries @Ahajha Thank you so much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants