-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open62541 - Allow more clang versions #20892
Open62541 - Allow more clang versions #20892
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
test_package
switched to if
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
recipes/open62541/all/patches/0001-disable-sanitizers-1_3_x.patch
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
@Ahajha Will this be squash merged? The history is not needed imho. |
Yes, the commits are squashed. |
This comment has been minimized.
This comment has been minimized.
@Ahajha Who do I need to ask for a second review? |
Hopefully Ruben will get to it soon, I think he's been a bit busy recently. Also my approval "doesn't count" so to speak, I don't have write access. |
Ok, so I still need a second person with write access to review this... |
@RubenRBS Can I help you in any way to get the reviews faster? :) |
@Ahajha Hmm, nothing happening here. How can I motivate someone with write access to review this PR? |
Conan v1 pipeline ✔️All green in build 20 (
Conan v2 pipeline ✔️
All green in build 20 ( |
Tbh, I wish I knew. I've had a PR sitting for a few weeks now, struggling to get a review myself. |
Arg... that's depressing. This is blocking other work for me. If this takes so long I will have to find a different solution. 😢 |
@Ahajha Which one is your PR? I will try something that might make me quite unpopular... |
Please don't. Regardless, it's a weekend. On Monday I'll try to ask in Slack (Cpplang) for some reviews. |
Ok , then I wait. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your patience, after looking into the initial reasons of why the version limits, this seems to be ok :)
@RubenRBS @uilianries @Ahajha Thank you so much :) |
Specify library name and version: open62541/1.3.8
Allows a broader variety of clang compiler versions. See issue #20579