-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
open62541 recipe forbids clang > 9 #20579
Comments
The only note I found was this: #3786 (comment) This is from 3 years ago, with the justification I'm guessing is that CCI only tested up to clang 9 at the time, and enough work went into fixing clang 9 that they assumed that no further version would work. So my guess is that really should be != 9 instead. |
Is this something that could be changed? I would like to build the package using clang-15. |
Also what is the purpose of a check like this? |
@lbckmnn I guess it is just easier to say it is not supported than actually dealing with complaints when it does not compile. @Ahajha I can see in the original open62541 Repo that they also build with clang 11. Is it possible that this is not longer relevant for newer versions of open62541? How can I change the package or help to change it? |
@lbckmnn In the CI for this repo, it tries to build the package with various configurations, one of those being compiler version. It looks like currently it builds with clang 12 and 13 (of course you can build with others in theory, just these are checked and uploaded as binaries. Others must be built from source). If that configuration were to fail, it would be treated as a CI failure, so this is in place to make it known to CI that it will fail, so just skip it and treat as a "success". Of course, this can get out of sync, so there is always a goal to support the widest array of configurations. @Kischy There is a contributing guide, but essentially you can fork and make a pull request. I believe you should be able to just remove the maximum clang version check, and that will automatically rebuild the packages. |
@Ahajha Ok, I will do that. Is removing the version check the correct way to go? I would leave the check for open62541 versions below 1.3.8. |
The recipe of open62541 allows only certain compiler versions.
conan-center-index/recipes/open62541/all/conanfile.py
Lines 218 to 226 in 3e1a99d
Is there any reason for that?
the latest version seems to work just fine with clang16 and clang11 and I didn't find anything about this in the open62541 documentation.
The text was updated successfully, but these errors were encountered: