Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open62541 recipe forbids clang > 9 #20579

Open
lbckmnn opened this issue Oct 15, 2023 · 8 comments
Open

open62541 recipe forbids clang > 9 #20579

lbckmnn opened this issue Oct 15, 2023 · 8 comments

Comments

@lbckmnn
Copy link

lbckmnn commented Oct 15, 2023

The recipe of open62541 allows only certain compiler versions.

max_clang_version = "8" if Version(self.version) < "1.1.0" else "9"
if self.settings.compiler == "clang" and Version(self.settings.compiler.version) > max_clang_version:
raise ConanInvalidConfiguration(
"Open62541 supports Clang up to {} compiler version".format(max_clang_version))
if self.settings.compiler == "clang":
if Version(self.settings.compiler.version) < "5":
raise ConanInvalidConfiguration(
"Older clang compiler version than 5.0 are not supported")

Is there any reason for that?
the latest version seems to work just fine with clang16 and clang11 and I didn't find anything about this in the open62541 documentation.

@Ahajha
Copy link
Contributor

Ahajha commented Oct 18, 2023

The only note I found was this: #3786 (comment)

This is from 3 years ago, with the justification I'm guessing is that CCI only tested up to clang 9 at the time, and enough work went into fixing clang 9 that they assumed that no further version would work. So my guess is that really should be != 9 instead.

@Kischy
Copy link
Contributor

Kischy commented Oct 30, 2023

Is this something that could be changed? I would like to build the package using clang-15.

@lbckmnn
Copy link
Author

lbckmnn commented Oct 30, 2023

Also what is the purpose of a check like this?
If it is not possible to build the library with a specific compiler, the build will just fail anyway.

@Kischy
Copy link
Contributor

Kischy commented Oct 30, 2023

Also what is the purpose of a check like this? If it is not possible to build the library with a specific compiler, the build will just fail anyway.

@lbckmnn I guess it is just easier to say it is not supported than actually dealing with complaints when it does not compile.

@Ahajha I can see in the original open62541 Repo that they also build with clang 11. Is it possible that this is not longer relevant for newer versions of open62541? How can I change the package or help to change it?

@Ahajha
Copy link
Contributor

Ahajha commented Oct 30, 2023

Also what is the purpose of a check like this? If it is not possible to build the library with a specific compiler, the build will just fail anyway.

@lbckmnn In the CI for this repo, it tries to build the package with various configurations, one of those being compiler version. It looks like currently it builds with clang 12 and 13 (of course you can build with others in theory, just these are checked and uploaded as binaries. Others must be built from source). If that configuration were to fail, it would be treated as a CI failure, so this is in place to make it known to CI that it will fail, so just skip it and treat as a "success". Of course, this can get out of sync, so there is always a goal to support the widest array of configurations.

@Kischy There is a contributing guide, but essentially you can fork and make a pull request. I believe you should be able to just remove the maximum clang version check, and that will automatically rebuild the packages.

@Kischy
Copy link
Contributor

Kischy commented Nov 2, 2023

@Ahajha Ok, I will do that. Is removing the version check the correct way to go? I would leave the check for open62541 versions below 1.3.8.

@Kischy
Copy link
Contributor

Kischy commented Nov 2, 2023

@Ahajha Could you have a look at #20892 and see why the CI runs fail? I can't access the logs...

Edit: I found the log. The Access Request approval is pending

@Kischy
Copy link
Contributor

Kischy commented Nov 14, 2023

@Ahajha Could you review PR #20892?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants