Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-821 Move overrides to after karma has loaded #84

Merged
merged 1 commit into from
Aug 12, 2015

Conversation

JeroenVinke
Copy link
Contributor

fixes #77

Config.js is loaded after the overrides causing 404 errors on all files. When you move the override to after karma has loaded, the overrides work and tests run normally again.

@zewa666
Copy link
Contributor

zewa666 commented Aug 12, 2015

Funny I just found the solution few minutes after your PR, so yep agree that this should fix it. Good work @JeroenVinke 👍

@EisenbergEffect
Copy link

Please merge and release with this fix as soon as you can! We really need this.

@ghost
Copy link

ghost commented Aug 12, 2015

+1

@maxwellpeterson-wf
Copy link
Contributor

+1
@jayudey-wf let's merge this and do a 2.0.1-beta.2 release

@ghost
Copy link

ghost commented Aug 12, 2015

@maxwellpeterson-wf please do it today and remember to tag for npm!

@ghost
Copy link

ghost commented Aug 12, 2015

@maxwellpeterson-wf today as in 2 hours ago :)

@maxwellpeterson-wf
Copy link
Contributor

@robertbaker You have to understand that we have a QA and release process that we are required to go through internally. Our team is also very busy with a number of other things not related to this project, however, our QA does plan to get to this today. If that isn't quick enough for you, I'd recommend installing this specific branch of karma-jspm in your project. You can do so with the following command:

$ npm install "git+ssh://[email protected]:JeroenVinke/karma-jspm.git#master"

@EisenbergEffect
Copy link

@maxwellpeterson-wf Thanks for addressing this for us! We really appreciate you guys putting the effort in on this plugin.

@jayudey-wf jayudey-wf changed the title Move overrides to after karma has loaded CP-821 Move overrides to after karma has loaded Aug 12, 2015
@jayudey-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • installed into project consuming karma-jspm, verified that tasks were still working as expected
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Aug 12, 2015
 CP-821 Move overrides to after karma has loaded
@jayudey-wf jayudey-wf merged commit 09e22f0 into computmaxer:master Aug 12, 2015
@maxwellpeterson-wf
Copy link
Contributor

@robertbaker tag has been created and published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SystemJS 0.18 new baseURL behavior
5 participants