-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP-821 Move overrides to after karma has loaded #84
Conversation
Funny I just found the solution few minutes after your PR, so yep agree that this should fix it. Good work @JeroenVinke 👍 |
Please merge and release with this fix as soon as you can! We really need this. |
+1 |
+1 |
@maxwellpeterson-wf please do it today and remember to tag for npm! |
@maxwellpeterson-wf today as in 2 hours ago :) |
@robertbaker You have to understand that we have a QA and release process that we are required to go through internally. Our team is also very busy with a number of other things not related to this project, however, our QA does plan to get to this today. If that isn't quick enough for you, I'd recommend installing this specific branch of karma-jspm in your project. You can do so with the following command: $ npm install "git+ssh://[email protected]:JeroenVinke/karma-jspm.git#master" |
@maxwellpeterson-wf Thanks for addressing this for us! We really appreciate you guys putting the effort in on this plugin. |
QA Resource Approval: +10
Merging into master. |
CP-821 Move overrides to after karma has loaded
@robertbaker tag has been created and published. |
fixes #77
Config.js is loaded after the overrides causing 404 errors on all files. When you move the override to after karma has loaded, the overrides work and tests run normally again.