Skip to content
This repository has been archived by the owner on Jun 1, 2022. It is now read-only.

Fix broken test #131

Closed
wants to merge 2 commits into from
Closed

Fix broken test #131

wants to merge 2 commits into from

Conversation

bohnen
Copy link
Contributor

@bohnen bohnen commented Aug 6, 2015

  • fix unit tests (fix relative path issue, flickr -> github users)

@zewa666
Copy link
Member

zewa666 commented Aug 7, 2015

@EisenbergEffect I've checked those modifications and they work. On-Top of that there is currently a bug with Karma-JPSM (computmaxer/karma-jspm#77), which based on the outcome, might require a slight modification of our karma.configuration file. Nevertheless I think we're good to merge this one already.

@davismj
Copy link
Member

davismj commented Aug 12, 2015

It seems that karma-jspm is not being actively maintained...

@zewa666
Copy link
Member

zewa666 commented Aug 12, 2015

I think we found the solution, thanks to the help of our community users. computmaxer/karma-jspm#84

I'd welcome anyone to weigh in into the PR so that the karma-jspm people see that its important 👍

@zewa666
Copy link
Member

zewa666 commented Aug 13, 2015

@EisenbergEffect on top of the changes from this PR please also update the karma-jspm version in package.json to -> "karma-jspm": "2.0.1-beta.2". Checked it out now and all the tests are passing now with the new tag 👍

@davismj
Copy link
Member

davismj commented Aug 13, 2015

i'll go ahead and submit a pull request with the updated package json

@davismj
Copy link
Member

davismj commented Aug 13, 2015

@EisenbergEffect Please use my pull request instead, which includes this pull request from @bohnen as well as the change proposed by @zewa666.

@EisenbergEffect
Copy link
Contributor

Ok. I'm closing this PR then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants