Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the version output when running assume -v #762

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

chrnorm
Copy link
Contributor

@chrnorm chrnorm commented Sep 26, 2024

What changed?

The output of the CLI version printer is now wrapped in assumeprint.SafeOutput, so that assume --version and assume -v print the actual version rather than an empty string.

Why?

Fixes #723.

We need to prefix text written to stdout with GrantedOutput, otherwise it is swallowed by the assume shell script. This wasn't implemented for the assume VersionPrinter, so no output was shown.

How did you test it?

sudo make cli 
dassume -v 

The version is printed now:

❯ dassume -v
Granted version: dev

Potential risks

Low risk as only the version printer is affected by the change.

Is patch release candidate?

Yes

Copy link
Contributor

@VigneshSelvaraj96 VigneshSelvaraj96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and verified that -v and --v print the same output instead of an empty string.
image

@VigneshSelvaraj96 VigneshSelvaraj96 merged commit 3cbbe71 into main Sep 26, 2024
3 checks passed
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Oct 11, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [common-fate/granted](https://github.com/common-fate/granted) | minor | `v0.33.0` -> `v0.35.1` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>common-fate/granted (common-fate/granted)</summary>

### [`v0.35.1`](https://github.com/common-fate/granted/releases/tag/v0.35.1)

[Compare Source](common-fate/granted@v0.35.0...v0.35.1)

This release includes bug fixes for the RDS plugin.

#### What's Changed

-   Remove Grant is activated message, use new Grant Output API by [@&#8203;JoshuaWilkes](https://github.com/JoshuaWilkes) in common-fate/granted#769
-   Improve how RDS proxy command handles grant expiry and proxy connection errors by [@&#8203;JoshuaWilkes](https://github.com/JoshuaWilkes) in common-fate/granted#770

**Full Changelog**: common-fate/granted@v0.35.0...v0.35.1

### [`v0.35.0`](https://github.com/common-fate/granted/releases/tag/v0.35.0)

[Compare Source](common-fate/granted@v0.34.1...v0.35.0)

#### AWS IAM Identity Center phishing protection

![Frame 13](https://github.com/user-attachments/assets/4e315c6c-694f-45bf-84bc-7f56f1df47d2)

This release adds support for the new [Granted browser extension for Chrome](https://chromewebstore.google.com/detail/granted/cjjieeldgoohbkifkogalkmfpddeafcm), which confirms the user code automatically when logging in to AWS IAM Identity Center. This makes authenticating faster and protects against being phished for your AWS credentials. [Read more in our announcement blog post here.](https://www.commonfate.io/blog/granted-mitigates-aws-phishing).

[Follow our install guide here to get set up with Granted.](https://docs.commonfate.io/granted/getting-started)

#### What's Changed

-   add fixes to setting custom browser by [@&#8203;meyerjrr](https://github.com/meyerjrr) in common-fate/granted#760
-   Fix the version output when running `assume -v` by [@&#8203;chrnorm](https://github.com/chrnorm) in common-fate/granted#762
-   Added support for manual setting of PassDir to avoid pass password pollution in default location by [@&#8203;VigneshSelvaraj96](https://github.com/VigneshSelvaraj96) in common-fate/granted#761
-   Add apigw -> apigateway service shortcut by [@&#8203;alexjurkiewicz](https://github.com/alexjurkiewicz) in common-fate/granted#763
-   Add AWS IAM Identity Center device code flow automation by [@&#8203;chrnorm](https://github.com/chrnorm) in common-fate/granted#765

#### New Contributors

-   [@&#8203;VigneshSelvaraj96](https://github.com/VigneshSelvaraj96) made their first contribution in common-fate/granted#761

**Full Changelog**: common-fate/granted@v0.34.2...v0.35.0

### [`v0.34.1`](https://github.com/common-fate/granted/releases/tag/v0.34.1)

[Compare Source](common-fate/granted@v0.34.0...v0.34.1)

This release fixes a folder permissions issue introduced in v0.34.0, and fixes an issue with using `assume -s ram` to open Resource Access Manager. A big thankyou to contributors [@&#8203;jpbelleau](https://github.com/jpbelleau) and [@&#8203;wayne-folkes](https://github.com/wayne-folkes).

#### What's Changed

-   Add RAM (Resource Access Manager) by [@&#8203;wayne-folkes](https://github.com/wayne-folkes) in common-fate/granted#757
-   Revert "update file permissions to read/write ([#&#8203;751](common-fate/granted#751))" by [@&#8203;chrnorm](https://github.com/chrnorm) and [@&#8203;jpbelleau](https://github.com/jpbelleau) in common-fate/granted#755

**Full Changelog**: common-fate/granted@v0.34.0...v0.34.1

### [`v0.34.0`](https://github.com/common-fate/granted/releases/tag/v0.34.0)

[Compare Source](common-fate/granted@v0.33.0...v0.34.0)

#### What's Changed

-   Sort sso profiles by profile name by [@&#8203;shwethaumashanker](https://github.com/shwethaumashanker) in common-fate/granted#733
-   Fix using default duration on auto approved requests by [@&#8203;meyerjrr](https://github.com/meyerjrr) in common-fate/granted#748
-   Update file permissions to read/write by [@&#8203;meyerjrr](https://github.com/meyerjrr) in common-fate/granted#751
-   Implement custom templated launch for sso browser option by [@&#8203;meyerjrr](https://github.com/meyerjrr) in common-fate/granted#750

**Full Changelog**: common-fate/granted@v0.33.0...v0.34.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assume --version is not working
2 participants