Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using default duration on auto approved requests #748

Merged

Conversation

meyerjrr
Copy link
Contributor

@meyerjrr meyerjrr commented Sep 17, 2024

What changed?

Updated the access request hooks to use the Duration returned by the batch ensure API to show how long access was requested for. Where a request is already active, the remaining duration is calculated.

Why?

Access requests that required access to be assigned with Common Fate was returning incorrect values for the duration on the request.

How did you test it?

Ran assume without the change and observed the bug present.
Reran the same command and got the expected output of the default duration.

With specifying duration

dassume  dev.test/Billing -d 1h
[i] You don't currently have access to dev.test/Billing, checking if we can request access... [target=AWS::Account::"123456789012", role=Billing, url=http://localhost:9090]
[WILL ACTIVATE] Billing access to test will be activated for 1h: http://localhost:8080/access/requests/req_2mBcrs8p9mF9Y7ZqaCEQcaoF7ZR
? Apply proposed access changes Yes
[i] Attempting to grant access...
? Reason for access (Required) test
[ACTIVATED] Billing access to test was activated for 1h: http://localhost:8080/access/requests/req_2mBcsCc6S5C0Z0dPyHMdXRQRBYz
[✔] [dev.test/Billing](ap-southeast-2) session credentials will expire in 1 hour

When not specifying duration, defaults to using the default duration

dassume  dev.test/Billing 
[i] You don't currently have access to dev.test/Billing, checking if we can request access... [target=AWS::Account::"123456789012", role=Billing, url=http://localhost:9090]
[WILL ACTIVATE] Billing access to test will be activated for 5m: http://localhost:8080/access/requests/req_2mBcw1qVFNVrRfxVZ13nc8iuhj6
? Apply proposed access changes Yes
[i] Attempting to grant access...
? Reason for access (Required) test
[ACTIVATED] Billing access to test was activated for 5m: http://localhost:8080/access/requests/req_2mBcwLqKRDxTUaEKq53Lt8FoQj8

Potential risks

Is patch release candidate?

Link to relevant docs PRs

@JoshuaWilkes
Copy link
Contributor

I've updated this PR to use the Duration field which was added a few months ago, this now reports exactly how long the grant was requested for, or how long is remaining on an active grant.

@JoshuaWilkes JoshuaWilkes merged commit b114bb5 into main Sep 19, 2024
3 checks passed
@JoshuaWilkes JoshuaWilkes deleted the fix-using-default-duration-on-auto-approved-requests branch September 19, 2024 01:05
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Oct 11, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [common-fate/granted](https://github.com/common-fate/granted) | minor | `v0.33.0` -> `v0.35.1` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>common-fate/granted (common-fate/granted)</summary>

### [`v0.35.1`](https://github.com/common-fate/granted/releases/tag/v0.35.1)

[Compare Source](common-fate/granted@v0.35.0...v0.35.1)

This release includes bug fixes for the RDS plugin.

#### What's Changed

-   Remove Grant is activated message, use new Grant Output API by [@&#8203;JoshuaWilkes](https://github.com/JoshuaWilkes) in common-fate/granted#769
-   Improve how RDS proxy command handles grant expiry and proxy connection errors by [@&#8203;JoshuaWilkes](https://github.com/JoshuaWilkes) in common-fate/granted#770

**Full Changelog**: common-fate/granted@v0.35.0...v0.35.1

### [`v0.35.0`](https://github.com/common-fate/granted/releases/tag/v0.35.0)

[Compare Source](common-fate/granted@v0.34.1...v0.35.0)

#### AWS IAM Identity Center phishing protection

![Frame 13](https://github.com/user-attachments/assets/4e315c6c-694f-45bf-84bc-7f56f1df47d2)

This release adds support for the new [Granted browser extension for Chrome](https://chromewebstore.google.com/detail/granted/cjjieeldgoohbkifkogalkmfpddeafcm), which confirms the user code automatically when logging in to AWS IAM Identity Center. This makes authenticating faster and protects against being phished for your AWS credentials. [Read more in our announcement blog post here.](https://www.commonfate.io/blog/granted-mitigates-aws-phishing).

[Follow our install guide here to get set up with Granted.](https://docs.commonfate.io/granted/getting-started)

#### What's Changed

-   add fixes to setting custom browser by [@&#8203;meyerjrr](https://github.com/meyerjrr) in common-fate/granted#760
-   Fix the version output when running `assume -v` by [@&#8203;chrnorm](https://github.com/chrnorm) in common-fate/granted#762
-   Added support for manual setting of PassDir to avoid pass password pollution in default location by [@&#8203;VigneshSelvaraj96](https://github.com/VigneshSelvaraj96) in common-fate/granted#761
-   Add apigw -> apigateway service shortcut by [@&#8203;alexjurkiewicz](https://github.com/alexjurkiewicz) in common-fate/granted#763
-   Add AWS IAM Identity Center device code flow automation by [@&#8203;chrnorm](https://github.com/chrnorm) in common-fate/granted#765

#### New Contributors

-   [@&#8203;VigneshSelvaraj96](https://github.com/VigneshSelvaraj96) made their first contribution in common-fate/granted#761

**Full Changelog**: common-fate/granted@v0.34.2...v0.35.0

### [`v0.34.1`](https://github.com/common-fate/granted/releases/tag/v0.34.1)

[Compare Source](common-fate/granted@v0.34.0...v0.34.1)

This release fixes a folder permissions issue introduced in v0.34.0, and fixes an issue with using `assume -s ram` to open Resource Access Manager. A big thankyou to contributors [@&#8203;jpbelleau](https://github.com/jpbelleau) and [@&#8203;wayne-folkes](https://github.com/wayne-folkes).

#### What's Changed

-   Add RAM (Resource Access Manager) by [@&#8203;wayne-folkes](https://github.com/wayne-folkes) in common-fate/granted#757
-   Revert "update file permissions to read/write ([#&#8203;751](common-fate/granted#751))" by [@&#8203;chrnorm](https://github.com/chrnorm) and [@&#8203;jpbelleau](https://github.com/jpbelleau) in common-fate/granted#755

**Full Changelog**: common-fate/granted@v0.34.0...v0.34.1

### [`v0.34.0`](https://github.com/common-fate/granted/releases/tag/v0.34.0)

[Compare Source](common-fate/granted@v0.33.0...v0.34.0)

#### What's Changed

-   Sort sso profiles by profile name by [@&#8203;shwethaumashanker](https://github.com/shwethaumashanker) in common-fate/granted#733
-   Fix using default duration on auto approved requests by [@&#8203;meyerjrr](https://github.com/meyerjrr) in common-fate/granted#748
-   Update file permissions to read/write by [@&#8203;meyerjrr](https://github.com/meyerjrr) in common-fate/granted#751
-   Implement custom templated launch for sso browser option by [@&#8203;meyerjrr](https://github.com/meyerjrr) in common-fate/granted#750

**Full Changelog**: common-fate/granted@v0.33.0...v0.34.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants