Chores: Update examples, RHL 3 & babel 6 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpfahler
force-pushed
the
chores
branch
3 times, most recently
from
1ac19ce to
a58cb6b
Compare
davidpfahler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are in a bit of a limbo.
react-hot-loaderversion 3 is about to be released, but (possibly among other things) is waiting on ErrorBoundaries in react, which is likely to land in the next react release.Because of this, I update the examples to reflect the current state of both deprecation and anticipation:
react-hot-loaderexample features the upcoming version 3 (currently 3.0.0-beta.2), but does not yet support error catching and rendering on updates, only on initial mount. This is the future, but it's not quite here.react-transform-catch-errorsexample shows how to catch and render errors with the deprecatedreact-transform-catch-errorsplugin. This is the way of the past, but it works today.If check out the PR, which brings ErrorBoundaries to react, and build react from source, you can use the RHL 3 example with hot reloading error capture today. When you clone the PR to your machine and build react (
npm install; npm run build) you can replace the react package in thenode_modulesfolder of the react-hot-loader example with thereactfolder inbuild/packages/.Please review these changes. None should be breaking or even be worth publishing to npm (that's why they are labeled "chores").