Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to react 14 #43

Closed
wants to merge 3 commits into from
Closed

Update examples to react 14 #43

wants to merge 3 commits into from

Conversation

colinmeinke
Copy link

  • Updated react-transform-catch-errors to use react 14.
  • Removed babel-plugin-react-hot example as babel-plugin-react-hot is depreciated.
  • Removed react-hot-loader-example example as react-hot-loader is depreciated.

Note: This pull request is based off of, and therefore includes, my babel 6 pull request.

Closes #29.

@colinmeinke colinmeinke mentioned this pull request Dec 27, 2015
@colinmeinke
Copy link
Author

@davidpfahler could you try clearing the travis node_modules cache and rerunning this test? Same issue with #42

@gaearon
Copy link
Contributor

gaearon commented Dec 27, 2015

I'd say react-hot-loader is still alive despite being deprecated, so I'd like to keep this example.

@colinmeinke
Copy link
Author

@gaearon no problem, I've re-added and updated react-hot-loader-example to 14.x, however, although the hot reloading is working it is not displaying redbox on error. Any ideas?

@davidpfahler
Copy link
Member

@colinmeinke I'm sorry, but I never had this problem before. How can I flush the node_modules cache in travis? Couldn't find anything about that functionality.

@colinmeinke
Copy link
Author

@davidpfahler
Copy link
Member

@colinmeinke I cleared the cache and reran your PR.

@gaearon gaearon mentioned this pull request Feb 2, 2016
@davidpfahler
Copy link
Member

@colinmeinke Sorry for not using your work here. I had to dig through this myself, because it was entangled with some other stuff I wanted to bring to the examples. I would very much appreciate it, if you could join the discussion on this PR and possibly review my changes. Most of this is in anticipation of react-hot-loader 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants