Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solver cabal install hint #4099

Closed
wants to merge 2 commits into from
Closed

Solver cabal install hint #4099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dea6e5e
fix: Recover from all errors on calling `proc "cabal" --numeric-version`
adrianwong Jun 20, 2018
f8f8e5d
docs: Add bugfix description to changelog
adrianwong Jun 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ Bug fixes:
* When prompting users about saving their Hackage credentials on upload,
flush to stdout before waiting for the response so the prompt actually
displays. Also fixes a similar issue with ghci target selection prompt.
* If `cabal` is not on PATH, running `stack solver` now prompts the user
to run `stack install cabal-install`


## v1.7.1
Expand Down
2 changes: 1 addition & 1 deletion src/Stack/Setup.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1353,7 +1353,7 @@ buildInGhcjsEnv envConfig boptsCli = do

getCabalInstallVersion :: (HasProcessContext env, HasLogFunc env) => RIO env (Maybe Version)
getCabalInstallVersion = do
ebs <- proc "cabal" ["--numeric-version"] $ tryAny . readProcessStdout_
ebs <- tryAny $ proc "cabal" ["--numeric-version"] readProcessStdout_
case ebs of
Left _ -> return Nothing
Right bs -> Just <$> parseVersion (T.dropWhileEnd isSpace (T.decodeUtf8 (LBS.toStrict bs)))
Expand Down