Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solver cabal install hint #4099

Closed
wants to merge 2 commits into from
Closed

Solver cabal install hint #4099

wants to merge 2 commits into from

Conversation

adrianwong
Copy link
Contributor

Resolves #3841.

Recover from all errors on invoking proc "cabal" --numeric-version.

This reintroduces the helpful hint to stack install cabal-install if stack solver is run when cabal is not on PATH, instead of displaying the exception message propagated from RIO (thanks for the help, @mgsloan!).

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

  • Ran stack solver on a project using an existing version of stack, with and without cabal on PATH
  • Ran stack solver on the same project using the modified stack, with and without cabal on PATH. Verified that the helpful hint was displayed without cabal on PATH; verified that stack solver ran without issue with cabal on PATH

@adrianwong adrianwong closed this Jun 20, 2018
@adrianwong adrianwong deleted the solver-cabal-install-hint branch June 20, 2018 23:16
@adrianwong
Copy link
Contributor Author

Note: closed and resubmitted in #4100 to rerun tests, as Travis was being flaky. Should have just reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant