-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds integration test for #3396 #3502
Adds integration test for #3396 #3502
Conversation
cc @snoyberg |
67e1f18
to
516c382
Compare
Bah, let me know if I should get rid of the style changes in |
|
516c382
to
044c556
Compare
@snoyberg I've added the necessary steps and removed the files we don't need, as well as the formatting. One note though: We don't really need the invalid |
createDirectory (home </> ".stack" </> "indices" </> "CustomIndex") | ||
copy "CustomIndex/00-index.tar" (home </> ".stack" </> "indices" </> "CustomIndex" </> "00-index.tar") | ||
copy "CustomIndex/01-index.tar" (home </> ".stack" </> "indices" </> "CustomIndex" </> "01-index.tar") | ||
copy "CustomIndex/01-index.cache" (home </> ".stack" </> "indices" </> "CustomIndex" </> "01-index.cache") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better not to copy over the cache
, especially since the format will change over time. Also, I'd be interested in whether this works without the 00-index.tar
file as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snoyberg good point. Removing the cache file. Also, 00-index.tar is not needed so removing that as well.
I'd probably leave off the unnecessary tarballs for now, it shouldn't be too hard to recreate something similar. |
The provided test package (dinamo), that is part of a custom snapshot has a malformed cabal file. Specifically, it's setting the required cabal version to an invalid number (9001). This test makes sure that stack does not care about this if we do not actually use the package in our project.
044c556
to
550016f
Compare
@snoyberg Updated (removed tarballs that we don't need right now). |
The provided test package (dinamo), that is part of a custom snapshot has
a malformed cabal file. Specifically, it's setting the required cabal
version to an invalid number (9001). This test makes sure that
stack does not care about this if we do not actually use the package
in our project.
Closes #3396