-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat cabal file parsing failures from index as non-fatal #3396
Milestone
Comments
denibertovic
added a commit
to denibertovic/stack
that referenced
this issue
Oct 20, 2017
The provided test package (dinamo), that is part of a custom snapshot has a malformed cabal file. Specifically, it's setting the required cabal version to an invalid number (9001). This test makes sure that stack does not care about this if we do not actually use the package in our project.
denibertovic
added a commit
to denibertovic/stack
that referenced
this issue
Oct 20, 2017
The provided test package (dinamo), that is part of a custom snapshot has a malformed cabal file. Specifically, it's setting the required cabal version to an invalid number (9001). This test makes sure that stack does not care about this if we do not actually use the package in our project.
Based on testing by @denibertovic, this is already implemented as needed. I'm going to move this out of the P0 milestone to avoid blocking the release, and will follow up with Deni on #3502 to get an integration test added. |
denibertovic
added a commit
to denibertovic/stack
that referenced
this issue
Oct 24, 2017
The provided test package (dinamo), that is part of a custom snapshot has a malformed cabal file. Specifically, it's setting the required cabal version to an invalid number (9001). This test makes sure that stack does not care about this if we do not actually use the package in our project.
denibertovic
added a commit
to denibertovic/stack
that referenced
this issue
Oct 24, 2017
The provided test package (dinamo), that is part of a custom snapshot has a malformed cabal file. Specifically, it's setting the required cabal version to an invalid number (9001). This test makes sure that stack does not care about this if we do not actually use the package in our project.
tswelsh
pushed a commit
to tswelsh/stack
that referenced
this issue
Nov 7, 2017
The provided test package (dinamo), that is part of a custom snapshot has a malformed cabal file. Specifically, it's setting the required cabal version to an invalid number (9001). This test makes sure that stack does not care about this if we do not actually use the package in our project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some recent issues come from the fact that Stack has been (perhaps overzealously) too strict in its parsing logic. Given that we can't properly rely on upstream sources always providing input which is compatible with the deployed version of the Cabal file parser, we should relax this logic. (I made the original decision implicitly to be strict in parsing, due to past experiences with tools like packdeps and weird corner cases around BOMs, but this reasoning no longer applies.)
Here are some examples of things we should be less strict about:
We need to accept that there is no Cabal format specification, and as it stands now, the Cabal library implementation is the library.
The text was updated successfully, but these errors were encountered: