check input args

[86667]

#261

[lawlawlaw]

Will be fine once you've updated util_tests.cpp.

[lawlawlaw]

In the old test case, arguments were either ignored, or they ended up both MapArgs and MapMultiArgs.

-ignored is ignored anyway because it is the first argument (program name) so it should not be in the valid arguments list.

The new behaviour we want is for invalid arguments to result in an error so this test needs to change.

Add more test cases parsing invalid parameters and include some try/catch statements and assert that the correct error was thrown.

Are -par and -pid really valid program arguments or are the included for the sake of the test?

I see that "f" and everything after it is ignored. I can't think of why that would be the best outcome from missing out a "-" in the arguments list. Consider modifying the code to throw an error in this case as well.

[86667]

-par sets the number of script verification threads and -pid sets the location of bitcoin.pid the file.