oceand runs without complaining with invalid options

[lawlawlaw]

If oceand is started with an invalid e.g. misspelled option, it will carry on without complaining. This can result in errors creeping into config files due to spelling mistakes etc.

I propose to upgrade the current option parsing system to stop with an appropriate error message if any option in the option map is not present in a predetermined list of valid options.

[nkostoulas]

Might be worth checking upstream elements/bitcoin. They have changed the whole argument system.

[86667]

Bitcoin/Elements now store all possible arguments in an Arg struct, along with arguments provided by the user so checking for correct input is easy. It is a big change though and would take some time, but may be worth doing bitcoin/bitcoin#9243.

Other hacky options are:

• generate the helpMessage strings, parse into a list of all arguments and check inputs against it
• store a seperate list of argument strings to check against

[nkostoulas]

Yeah big change and a bit fiddly. I've added this to the list of upstream changes we should consider (https://github.com/commerceblock/ocean/milestone/4) #240 already. Not sure if it's worth doing at the moment but if we do this we do it proper.

[86667]

Yup, I'll start looking into it now and get an idea of how big the job is