Merge pull request #250 from commerceblock/fix/pegin-logic

Logic bug causing misinformation when eth tx is null (node syncing)
commerceblock · Oct 25, 2019 · be8600c · be8600c
2 parents c4f166f + 7982ca5
commit be8600c
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/wallet/rpcwallet.cpp b/src/wallet/rpcwallet.cpp
@@ -5069,7 +5069,7 @@ UniValue validateethpegin(const JSONRPCRequest& request)
     pubKey.Decompress(); // eth addresses require full pubkey
 
     std::string strFailReason;
-    if (!IsValidEthPegin(tx, nAmount, pubKey, strFailReason) && IsConfirmedEthPegin(tx, strFailReason)) {
+    if (!IsValidEthPegin(tx, nAmount, pubKey, strFailReason) || !IsConfirmedEthPegin(tx, strFailReason)) {
         throw JSONRPCError(RPC_TRANSACTION_ERROR, strFailReason);
     }
     return true;