Skip to content

Commit

Permalink
Logic bug causing misinformation when eth tx is null (node syncing)
Browse files Browse the repository at this point in the history
  • Loading branch information
nkostoulas committed Oct 25, 2019
1 parent c4f166f commit 7982ca5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/wallet/rpcwallet.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5069,7 +5069,7 @@ UniValue validateethpegin(const JSONRPCRequest& request)
pubKey.Decompress(); // eth addresses require full pubkey

std::string strFailReason;
if (!IsValidEthPegin(tx, nAmount, pubKey, strFailReason) && IsConfirmedEthPegin(tx, strFailReason)) {
if (!IsValidEthPegin(tx, nAmount, pubKey, strFailReason) || !IsConfirmedEthPegin(tx, strFailReason)) {
throw JSONRPCError(RPC_TRANSACTION_ERROR, strFailReason);
}
return true;
Expand Down

0 comments on commit 7982ca5

Please sign in to comment.