Allow history command to be executed while asb is running by opening database in read-only mode #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
binarybaron
approved these changes
Jul 22, 2024
|
Can you add a changelog entry as well? Just a small one-liner that this is now possible (running history command while asb is running) |
binarybaron
changed the title
binarybaron
changed the title
binarybaron
changed the title
…to sqlite-readonly-history
binarybaron
merged commit 5b94850
into
comit-network:sqlite-readonly-history
29 checks passed
7 tasks
binarybaron
pushed a commit
to UnstoppableSwap/core
that referenced
this pull request
Sep 17, 2024
…database in read-only mode (comit-network#1722)
binarybaron
added a commit
to UnstoppableSwap/core
that referenced
this pull request
Sep 17, 2024
This applies the following PRs from upstream to our fork: * fix(asb): Allow history command to be run while asb is running (comit-network#1724) * Allow history command to be executed while asb is running by opening database in read-only mode (comit-network#1722) --------- Co-authored-by: einliterflasche <[email protected]> Co-authored-by: Einliterflasche <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.