Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(asb): Allow history command to be run while asb is running #1717

Closed
wants to merge 1 commit into from

Conversation

binarybaron
Copy link
Collaborator

No description provided.

@binarybaron binarybaron requested a review from delta1 July 18, 2024 15:21
@binarybaron
Copy link
Collaborator Author

@Einliterflasche You can review this when you have time

Copy link
Collaborator

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - untested

I think it's worth adding a changelog entry so it will be listed with the next release

@Einliterflasche
Copy link
Contributor

Einliterflasche commented Jul 19, 2024

I don't know how you feel about this, but I feel we could use something like enum AccessMode { ReadOnly, ReadWrite } instead of a bool, just to make things clearer. I could go ahead and implement it if you agree in principal but find it boring :)

@binarybaron
Copy link
Collaborator Author

I don't know how you feel about this, but I feel we could use something like enum AccessMode { ReadOnly, ReadWrite } instead of a bool, just to make things clearer. I could go ahead and implement it if you agree in principal but find it boring :)

Sounds good!

@binarybaron
Copy link
Collaborator Author

Feel free to open a new PR based on my branch

@binarybaron
Copy link
Collaborator Author

superseded by #1722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants