Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use comfyui_frontend_package pypi package to manage frontend dependency (Frontend v1.10.17) #7021

Merged
merged 9 commits into from
Mar 2, 2025
Merged

Use comfyui_frontend_package pypi package to manage frontend dependency (Frontend v1.10.17) #7021

merged 9 commits into from
Mar 2, 2025
+14 −335,152

Conversation

huchenlei
Copy link
Collaborator

@huchenlei huchenlei commented Feb 28, 2025 •
edited
Loading

  • Remove web/
  • Remove update-frontend.yml gh action
  • Add comfyui-frontend-package as pip dependency
  • Update frontend to v1.10.17

Ref: https://pypi.org/project/comfyui-frontend-package/

Changelog (1.10.0 - 1.10.17)

Features

BugFixes

Misc

@huchenlei huchenlei added the Frontend Issue relates to the frontend UI (litegraph). label Feb 28, 2025
@huchenlei huchenlei marked this pull request as draft February 28, 2025 19:25
@huchenlei huchenlei marked this pull request as ready for review February 28, 2025 19:39
@huchenlei huchenlei changed the title Use comfyui_frontend_package pypi package to manage frontend dependency Use comfyui_frontend_package pypi package to manage frontend dependency (Frontend v1.10.17) Feb 28, 2025
@comfyanonymous
Copy link
Owner

I think the only thing missing is something that warns the user on startup if they have not updated the frontend pip package.

@huchenlei
Copy link
Collaborator Author

huchenlei commented Feb 28, 2025 •
edited
Loading

I think the only thing missing is something that warns the user on startup if they have not updated the frontend pip package.

Do we have an easy way to check the package version specified in requirement.txt? I think the desktop side has check on whether the pip environment satisfies the requirement.txt. Do we want to also bring that logic to the main repo?

@huchenlei
Copy link
Collaborator Author

I think the only thing missing is something that warns the user on startup if they have not updated the frontend pip package.

Overall I think this should be a separate project. Users update via ComfyUI manager should automatically have the deps updated.

@huchenlei huchenlei mentioned this pull request Feb 28, 2025
Merged
@comfyanonymous
Copy link
Owner

At least there needs to be a warning if there is no frontend package installed to warn users who are doing update with git pull only.

@comfyanonymous comfyanonymous mentioned this pull request Feb 28, 2025
Open
@huchenlei
Copy link
Collaborator Author

At least there needs to be a warning if there is no frontend package installed to warn users who are doing update with git pull only.

Done.

@mcmonkey4eva
Copy link
Contributor

Is --front-end-version cli arg still relevant to use, or is it entirely pip install @whatever now?

@huchenlei
Copy link
Collaborator Author

Is --front-end-version cli arg still relevant to use, or is it entirely pip install @whatever now?

--front-end-version cli arg still works, but alternatively you can also pip install @whatever now.

@huchenlei huchenlei mentioned this pull request Mar 1, 2025
Merged
@comfyanonymous comfyanonymous merged commit 04cf0cc into master Mar 2, 2025
6 checks passed
@huchenlei huchenlei deleted the frontend_package branch March 2, 2025 19:58
huchenlei added a commit to Comfy-Org/ComfyUI_frontend_setup_action that referenced this pull request Mar 2, 2025
@huchenlei
Update action.yaml
df231ca 
Sync comfyanonymous/ComfyUI#7021
This was referenced Mar 2, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webfiltered webfiltered Awaiting requested review from webfiltered webfiltered is a code owner

@pythongosssss pythongosssss Awaiting requested review from pythongosssss pythongosssss is a code owner

@yoland68 yoland68 Awaiting requested review from yoland68 yoland68 is a code owner

@robinjhuang robinjhuang Awaiting requested review from robinjhuang robinjhuang is a code owner

@ltdrdata ltdrdata Awaiting requested review from ltdrdata ltdrdata is a code owner

@comfyanonymous comfyanonymous Awaiting requested review from comfyanonymous comfyanonymous is a code owner

@Kosinkadink Kosinkadink Awaiting requested review from Kosinkadink Kosinkadink is a code owner

Assignees
No one assigned
Labels
dependencies Frontend Issue relates to the frontend UI (litegraph). Important
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huchenlei @comfyanonymous @mcmonkey4eva