Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize translation keys in template card component #2574

Merged
merged 3 commits into from
Feb 16, 2025

Conversation

christian-byrne
Copy link
Collaborator

@christian-byrne christian-byrne commented Feb 16, 2025

Converts dots to dashes in template card component translation keys. Dots are reserved as path separators (e.g. 'category.key').

Also fixes misnamed key in area composition category.

┆Issue is synchronized with this Notion page by Unito

Copy link
Member

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use

export function normalizeI18nKey(key: string) {
return key.replace(/\./g, '_')
}
instead?

@huchenlei huchenlei merged commit e3234aa into main Feb 16, 2025
10 checks passed
@huchenlei huchenlei deleted the template-translation-fix branch February 16, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants