Fix Detekt tests #4019
Merged
Fix Detekt tests #4019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaoyi
added a commit
that referenced
this pull request
Nov 25, 2024
Some follow ups after investigating #4019 * Make the server's `ServerSocket` fixed per-server-process rather than per-run, removing the race condition of the client reading a stale `serverPort` that differs from what the server is currently listening on * Make sure we delete all per-run files when starting a new run, so we can be sure we don't get confused by reading stale metadata * Clean up the error handling of `ServerLauncher#run` to avoid swallowing exceptions silently * Improve the comprehensiveness of `server.log` to make it easier to see problems with multiple server processes overlapping
lefou
reviewed
Nov 25, 2024
| @@ -21,7 +21,7 @@ trait DetektModule extends KotlinModule { | |||
|
|
|||
| private def detekt0() = T.task { | |||
|
|
|||
| val args = detektOptions() ++ Seq("-i", PathRef(T.workspace).path.toString()) ++ | |||
There was a problem hiding this comment.
PathRef(T.workspace) is calculating an expensive (but unused) hash doomed to change as soon as we finish the task and write the cache to disc (into T.workspace/"out").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow the
PathRef(T.workspace).pathis causing issues, but it's totally redundant since we can just useT.workspace. Walking theout/folder filesystem and hashing stuff seems to be causing problems with the file locks we use to ensure mutual exclusionSeems to make
example.kotlinlib.linting[1-detekt].local.testpass reliably where previously it was very flaky