Improve serverPort handling in client server protocol
#4018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaoyi
changed the title
serverPort race condition in client server protocolserverPort handling in client server protocol
lihaoyi
force-pushed
the
fix-server-launcher
branch
from
b33e8e2 to
e1002d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some follow ups after investigating #4019
Make the server's
ServerSocketfixed per-server-process rather than per-run, removing the race condition of the client reading a staleserverPortthat differs from what the server is currently listening onMake sure we delete all per-run files when starting a new run, so we can be sure we don't get confused by reading stale metadata
Clean up the error handling of
ServerLauncher#runto avoid swallowing exceptions silentlyImprove the comprehensiveness of
server.logto make it easier to see problems with multiple server processes overlapping