ScalaPB: various fix and improves #1027
Conversation
chikei
commented
Dec 3, 2020
chikei
commented
- fix destination path issue mentioned in ScalaPB additional args #1002 (comment)
- isolated classloader as ScalaPB: use isolated classloader #1026
- use T.worker
There was a problem hiding this comment.
Looks good to me. I added one question below.
Also, I just recognized that we have a commented-out test case for ScalaPB. Could you please check if this test works for you locally? I'm pretty sure we can handle non-abilities of the CI env better than commenting out. (Can't tell if there a equivalent to scalatest's assume in utest). I could imagine that this test will work on Github Actions as-is.
| override def scalaPBAdditionalArgs = T{Seq( | ||
| "--additional-test=..." | ||
| )} |
There was a problem hiding this comment.
What's the point of changing this?
There was a problem hiding this comment.
I was written from the version before last scalapb pr and thinking "additional-test" might easier for other people to reasoning and not specific for zio, not something matters in term of code execution.
|
Ya, I've verified the |
|
Thank you! |
