-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScalaPB additional args #1002
ScalaPB additional args #1002
Conversation
Also, refactored the code to allow retrieving the compilation args, this will ease testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your pull request looks good to me. Personally, I'd name the new target "additionalArgs" instead of "customArgs" as that better transports the fact that other args logic will still be preserved and it also matches what we have in other plugins, but that's only a suggestion and up to you.
But I'd like to have some more ScalaDoc, at least on the newly added and changed targets. These will help any user of the plugin who edits their buildfile in an IDE.
Also improved the functions documentation a little bit.
Thank you, @DanielBlanco ! |
Actually this PR might break ScalaPB module as ScalaPB module append You can test these by uncomment test |
OK, I'll try the test and come up with a solution if I can. Thx @chikei. |
@lefou can you please review, and let me know if I'm missing something?
The plan with this change is to allow additional args for scalaPBC, this means I can just do this in my code for zio-grpc to work: