Fixes for transact implementation (to match recent changes to contributiontransactlegacy extension) #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwire
force-pushed
the
transactupdates
branch
from
58c5f16 to
45bacad
Compare
|
@mattwire -> you'll want to be putting up the PR against 6.x |
|
I just changed the base to 6.x for this PR - but you'll need to rebase to resolve the conflicts. |
mattwire
force-pushed
the
transactupdates
branch
3 times, most recently
from
fa2c4cc to
8cd29dd
Compare
…utiontransactlegacy extension)
mattwire
force-pushed
the
transactupdates
branch
from
8cd29dd to
0692150
Compare
|
Closing this - we have resolved the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This simplifies and should fix some issues with missing keys for eg. IATs addresses.
Before
Convert to array then pass via API.
After
Pass params directly to doPayment method.
Technical Details
Comments