Refs #3260975 replaces Deprecated call to drupal_set_message

[stesi561]

Overview

Replace deprecated call to drupal_set_message - as per https://www.drupal.org/project/webform_civicrm/issues/3260975

Before

As the function is now removed from 9.x fatal error occurs instead of displaying an error to the user.

After

Error message is passed through to the user.

[stesi561]

I guess ideally this would include test coverage. If @KarinG can point me in the right direction as to where this might be best added happy to work on this.

[KarinG]

Hi Luke! I've kicked off the tests. Thank you for catching this.

Re: tests -> we have live/functional tests for Dummy, iATS Payments, Pay later and Stripe (see tests/src/FunctionalJavascript/ dir). If you wanted to add a e.g. PayPal test (or another payment processor that uses IPNs) - start with copying one of the existing Payment Processor test .php files and then you can add a success scenario and a fail scenario. I'm happy to connect with you over GoTo or Zoom as well if you like - to help you get going.

However for this fix - since it's not data critical - I'm happy to merge it once it passes existing tests.

[KarinG]

Oh I think that's a real error in CiviCRM dev-master. I'll dig in and pull out the browser artifacts.

[KarinG]

Downloading Artifacts -> phpunit_browser_output

[KarinG]

This is the iATS portal ->

[stesi561]

I see the same error on all PRs in the last 5 days. Seems like it was working 8 days ago.

[KarinG]

I don't see any Failed Payments on the iATS side of things for dev-master (and the others all Settled).

[KarinG]

Yes - something has gone sideways in CiviCRM dev-master.
RC is still good 👍

[KarinG]

I've posted on Mattermost -> Product-Maintenance channel -> sometimes Seamus will know exactly which PR may have caused an issue :-) https://chat.civicrm.org/civicrm/pl/esi8wyr7hbr8pkier88k99emdc

[KarinG]

Ok reproduced by upgrading one of my live sites to dev-master ->

[validationFailures] => Array
    (
        [0] => Array
            (
                [key] => ownerStreet
                [message] => Street is required.
            )

        [1] => Array
            (
                [key] => ownerCity
                [message] => City is required.
            )

        [2] => Array
            (
                [key] => ownerZip
                [message] => Postal Code is required.
            )

    )

[KarinG]

Ok tracked it down to this PR in civicrm core -> it touches the billing fields -> civicrm/civicrm-core#21583

Reverting that PR -> all is well again. Talking to Dave about how to solve this issue in civicrm core.

[mattwire]

@KarinG I think this might be fixed by #691

[jitendrapurohit]

@stesi561 Space fix required? should be 2 instead of 4 - https://www.drupal.org/docs/develop/standards/coding-standards#indenting

[stesi561]

Oops! Fixed.

[KarinG]

Thanks for editing Luke. Re-running this against D9 (5.35 - RC).