Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config consistency #266

Merged
merged 2 commits into from
Dec 16, 2021
Merged

config consistency #266

merged 2 commits into from
Dec 16, 2021

Conversation

shrimalmadhur
Copy link
Contributor

Fixes #194 .

Motivation

The bool config in rosetta-cli conf has variables with both *enabled and *disabled suffixes which is inconsistent and creates confusion.

Solution

Making all the config *disabled

Open questions

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7396

  • 0 of 2 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.983%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/results/construction_results.go 0 1 0.0%
pkg/results/data_results.go 0 1 0.0%
Totals Coverage Status
Change from base Build 7372: 0.0%
Covered Lines: 707
Relevant Lines: 1684
💛 - Coveralls

@shrimalmadhur shrimalmadhur merged commit 561f050 into master Dec 16, 2021
@shrimalmadhur shrimalmadhur deleted the madhur/config-overhaul branch December 16, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaying-peng xiaying-peng xiaying-peng approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Boolean config options consistency
3 participants
@shrimalmadhur @coveralls @xiaying-peng