Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boolean config options consistency #194

Closed
sosedoff opened this issue Dec 2, 2020 · 1 comment · Fixed by #266
Closed

Boolean config options consistency #194

sosedoff opened this issue Dec 2, 2020 · 1 comment · Fixed by #266
Labels
enhancement New feature or request

Comments

@sosedoff
Copy link
Contributor

sosedoff commented Dec 2, 2020

Does it make sense to always favor *_enabled option names for boolean variables?
Having both _enabled and _disabled is a bit confusing IMO.

Was the original purpose to set the values correctly without having to specify the options in the config file?
@sosedoff sosedoff added the enhancement New feature or request label Dec 2, 2020
@patrick-ogrady
Copy link
Contributor

Was the original purpose to set the values correctly without having to specify the options in the config file?

That is exactly right LOL. I have a config overhaul planned for this sprint, so hopefully will become much easier!

The other thing to note is that there is no way to set a 0 value for some options because 0 is interpreted as desiring default. 🤦

@shrimalmadhur shrimalmadhur mentioned this issue Dec 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config consistency coinbase/mesh-cli
2 participants
@sosedoff @patrick-ogrady