Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds basic federation status health check #35

Merged
merged 16 commits into from
Nov 22, 2024
Merged

Adds basic federation status health check #35

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
fbf0a2c
Adds basic federation health-check based on bundle comparison
jsnctl Nov 17, 2024
1389baa
Fixing typo
jsnctl Nov 17, 2024
8dfdef7
From linter - adding missing err handle
jsnctl Nov 17, 2024
ec217ae
Adding basic unit test, trimming return carriage
jsnctl Nov 17, 2024
8b50cd5
Adding case to cover bundle non-existence/deletion
jsnctl Nov 17, 2024
4900857
[From review] Pushing up err up the stack, using federation list in i…
jsnctl Nov 19, 2024
0de2a0d
Remove debug adjustment
jsnctl Nov 19, 2024
18f930f
Using JSON output of x509 authorities in bundle equality check
jsnctl Nov 20, 2024
c33cc5f
Adjustments for testability
jsnctl Nov 20, 2024
49fecb2
Adding federation list (with status) to int. test
jsnctl Nov 20, 2024
3b4e406
Rolling back to 1.22.7 now (no need for slices implementation of 1.23.*)
jsnctl Nov 20, 2024
3f53c4c
Merge branch 'main' into jsnctl/federation-status
jsnctl Nov 20, 2024
13f9f48
Update tests/integration/federation/test.sh
jsnctl Nov 21, 2024
324800c
[From review] Remove unrequired comparison
jsnctl Nov 21, 2024
9770880
[From review] Remove other comparison
jsnctl Nov 21, 2024
4c94ef0
Fix comparison
jsnctl Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions cmd/cofidectl/cmd/federation/federation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,12 +135,7 @@ func checkFederationStatus(ctx context.Context, kubeConfig string, from *trust_z
}

// Bundle does not exist at all on opposite trust domain
_, ok := compare[to].federatedBundles[from.TrustDomain]
jsnctl marked this conversation as resolved.
Show resolved Hide resolved
if !ok {
return "Unhealthy", nil
}

_, ok = compare[from].federatedBundles[to.TrustDomain]
_, ok := compare[from].federatedBundles[to.TrustDomain]
if !ok {
return "Unhealthy", nil
}
Expand Down
6 changes: 3 additions & 3 deletions tests/integration/federation/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,10 @@ function wait_for_pong() {
}

function post_deploy() {
if ./cofidectl federation list | grep Healthy; then
return
federations=$(./cofidectl federation list)
if echo "$federations" | grep Unhealthy >/dev/null; then
return 1
fi
exit 1
}

function down() {
Expand Down
Loading